Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support GHC 8.8.1 (fixes #19) #20

Merged
merged 3 commits into from
May 15, 2020
Merged

Support GHC 8.8.1 (fixes #19) #20

merged 3 commits into from
May 15, 2020

Conversation

maoe
Copy link
Contributor

@maoe maoe commented Nov 25, 2019

This PR adds support for GHC 8.8.1. The dependency on regex-tdfa-text has been superseded by the latest regex-tdfa.

@hvr
Copy link

hvr commented Nov 26, 2019

@maoe can you try this PR with the branch tip of https://github.com/haskell-hvr/regex-tdfa/commits/master ?

@maoe
Copy link
Contributor Author

maoe commented Nov 26, 2019

@maoe can you try this PR with the branch tip of https://github.com/haskell-hvr/regex-tdfa/commits/master ?

Sure. I confirmed locally that --filter option worked fine. I just pushed 31c096c to make sure CI passes with all GHC versions.

@maoe maoe changed the title WIP: Support GHC 8.8.1 Support GHC 8.8.1 Nov 26, 2019
@maoe maoe marked this pull request as ready for review November 26, 2019 07:43
@maoe maoe changed the title Support GHC 8.8.1 WIP: Support GHC 8.8.1 Nov 26, 2019
@maoe
Copy link
Contributor Author

maoe commented Nov 26, 2019

CI was fine with the latest regex-tdfa. I've removed the source-repository-package change. Now this is ready for review.

@maoe maoe changed the title WIP: Support GHC 8.8.1 Support GHC 8.8.1 Nov 26, 2019
@hvr
Copy link

hvr commented Nov 26, 2019

@maoe Btw, what are regexes being used in ghc-dump for? Are they performance critical? I'm asking because I'm searching for real-world benchmarks to measure how much -O2 vs -O1 matters for regex-tdfa

@hvr
Copy link

hvr commented Nov 26, 2019

@maoe
Copy link
Contributor Author

maoe commented Nov 29, 2019

@maoe Btw, what are regexes being used in ghc-dump for? Are they performance critical? I'm asking because I'm searching for real-world benchmarks to measure how much -O2 vs -O1 matters for regex-tdfa

ghc-dump-util uses regexes to filter output by a binding name. I'd say the performance is not critical unless the Core file is exceptionally big.

@maoe fyi, http://hackage.haskell.org/package/regex-tdfa-1.3.1.0

Thanks! I've confirmed this PR builds fine with the release version.

@maoe maoe changed the title Support GHC 8.8.1 Support GHC 8.8.1 (fixes #19) Dec 11, 2019
@maoe maoe mentioned this pull request Feb 7, 2020
@maoe maoe mentioned this pull request May 15, 2020
@bgamari bgamari merged commit 15b5ad7 into bgamari:master May 15, 2020
@maoe maoe deleted the ghc-8.8 branch May 16, 2020 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants