-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add mask statistics getter functions in Segmentation #231
base: main
Are you sure you want to change the base?
Conversation
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clean, can you add a couple of tests?
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #231 +/- ##
==========================================
- Coverage 61.84% 61.72% -0.12%
==========================================
Files 54 54
Lines 3866 3888 +22
==========================================
+ Hits 2391 2400 +9
- Misses 1475 1488 +13 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So the from_dicom
method actually IS specific to DICOMs, it's just a sitk.Image that's been loaded from a DICOM. The looping over the SegmentLabel
and SegmentSequence
is something that's specifically retrieved from a DICOM and doesn't exist in the niftis.
By mask I mean any non-zero voxels in the
label_image
.Functions added to the
Segmentation
class:roi_indices
dictionarylabel_image
label_image
label_image
- specifically didn't call this volume because it's not technically the volume in real world measurements, but useful for size comparison across patients or ROIsOther updates:
v
toverbose
inautopipeline
- had no idea what v was, this is more human readable