Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: decide between loadDICOMSITK and read_dicom_series #82

Open
jjjermiah opened this issue Dec 11, 2024 · 0 comments
Open

refactor: decide between loadDICOMSITK and read_dicom_series #82

jjjermiah opened this issue Dec 11, 2024 · 0 comments

Comments

@jjjermiah
Copy link
Contributor

jjjermiah commented Dec 11, 2024 •
edited
Loading

So I know I have this function and I used it in example.ipynb, but the actual pipeline uses the read_dicom_series function from med-imagetools. I feel like we should discuss what to do with the loadDICOMSITK function. I feel like we can either:

  1. Get rid of it and just use read_dicom_series everywhere
  2. Call read_dicom_series in loadDICOMSITK like how we call the MIT functions in loadRTSTRUCTSITK to load the RTSTRUCT

Thoughts?

Originally posted by @strixy16 in #81 (comment)
@jjjermiah jjjermiah changed the title So I know I have this function and I used it in example.ipynb, but the actual pipeline uses the read_dicom_series function from med-imagetools. I feel like we should discuss what to do with the loadDICOMSITK function. I feel like we can either: refactor: decide between loadDICOMSITK and read_dicom_series Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
READII-2-ROQC Pipeline
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jjjermiah