Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INFRA] Ignore www.incf.org link check.. unlikely to go away (hopefully) #2030

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

yarikoptic
Copy link
Collaborator

@yarikoptic yarikoptic commented Jan 16, 2025

Currently check fails

URL        `https://www.incf.org/'
Name       `INCF'
Parent URL file:///home/circleci/project/site/introduction.html, line 1795, col 2
Real URL   https://www.incf.org/
Check time 0.084 seconds
Result     Error: SSLError: HTTPSConnectionPool(host='www.incf.org', port=443): Max retries exceeded with url: / (Caused by SSLError(SSLCertVerificationError(1, '[SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: unable to get local issuer certifica...

possibly due to outdated collection of root certificates in the env where testing?

dunno, but we better address it since it brings overall CI to red quite often, causing fatigue and increasing likeliness to skip important issues.

edit: also sorted lines there for consistency etc

Currently check fails

    URL        `https://www.incf.org/'
    Name       `INCF'
    Parent URL file:///home/circleci/project/site/introduction.html, line 1795, col 2
    Real URL   https://www.incf.org/
    Check time 0.084 seconds
    Result     Error: SSLError: HTTPSConnectionPool(host='www.incf.org', port=443): Max retries exceeded with url: / (Caused by SSLError(SSLCertVerificationError(1, '[SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: unable to get local issuer certifica...

possibly due to outdated collection of root certificates in the env where testing?

dunno, but we better address it since it brings overall CI to red quite
often, causing fatigue and increasing likeliness to skip important issues.
Would be easier to find one, and to add one without thinking much
where etc
Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.45%. Comparing base (c16ab8d) to head (619f48b).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2030   +/-   ##
=======================================
  Coverage   82.45%   82.45%           
=======================================
  Files          17       17           
  Lines        1499     1499           
=======================================
  Hits         1236     1236           
  Misses        263      263           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yarikoptic
Copy link
Collaborator Author

ha -- it is as green as it can get ATM if I get it right. @Remi-Gau @effigies , may be a quick merge and close

with it for now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant