-
Notifications
You must be signed in to change notification settings - Fork 190
[ENH] Add audio/video recordings to behavioral experiments #2231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Add comprehensive support for audio and video recordings in behavioral experiments: - Add audio file extensions (mp3, wav) and video file extensions (mp4, mkv, avi) with corresponding _audio and _video suffixes - Document usage of audio/video recordings in beh directory for capturing vocalizations, speech, facial expressions, and body movements - Add metadata schema for audio/video device information and stream properties - Include privacy warnings about personally identifiable information in human subject recordings - Update behavioral experiments title to remove "with no neural recordings" restriction, clarifying data can be stored with or without neural recordings - Add examples for file organization including multi-angle recordings and split files - Define optional entities: task, acquisition, run, recording, split
…ee macros - Change section title from 'Behavioral experiments' to 'Behavioral recordings' - Convert file tree examples to use MACROS___make_filetree_example for consistent rendering - Address review comments from @yarikoptic in PR #2231
effigies
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this makes sense to me. It would be good to get some feedback from contributors to related BEPs, such as eye-tracking (20), motion (29), stimuli (44) and physio (45). Even if this PR doesn't propose adding this as an associated file to those data types, the potential is there and it's worth getting opinions and identifying potential conflicts.
cc @bids-standard/bep029 @bids-standard/bep044
cc @mszinte @julia-pfarr @oesteban (BEP020)
cc @m-miedema @smoia @SouravKulkarni (?) (BEP045)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2231 +/- ##
=======================================
Coverage 82.81% 82.81%
=======================================
Files 22 22
Lines 1693 1693
=======================================
Hits 1402 1402
Misses 291 291 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-authored-by: Chris Markiewicz <[email protected]>
Introduce `AudioBitDepth` and `CameraPosition` object definitions, and allow them as optional fields in BEH sidecar `AudioVideoStreams` to capture richer audio recording parameters and camera setup context.
|
See bids-standard/bids-examples#523 for an example dataset that validates under this schema |
|
@neuromechanist this PR has lots of overlap with your work on Please review here and also the since we should aim for consistency regarding the metadata on audio/video files etc |
|
My first suggestion (🤓) would be to request a BEP number for this PR from maintainers, as this is quite a change, and arguably/conceptually adds a new modality (although audio and video are being added in BEP044), which would require a BEP. I'll take it up to this week's maintainer meeting. |
|
OK, I have submitted a PR to the website to make this an official BEP here: bids-standard/bids-website#759 |
Comparison: vs PR #2022Summary
Key Differences
Notable Distinctions
These PRs are complementary—one captures what the subject does (behavioral recordings), the other captures what's shown to the subject (stimuli). @neuromechanist , thoughts? |
| description: | | ||
| Width of the video in pixels (for example, `1920`). | ||
| type: integer | ||
| minimum: 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be quite valuable to expose at least some details on the underlying codec(s) used for audio/video within the files, so e.g. we could assess if e.g. browser would play it etc?
|
thanks @bendichter - you have described the issue. if |
+1000 Indeed, add PET to the list. Looking beyond |
|
@oesteban, @satra, Thanks for engaging on this. I'm having trouble understanding what changes you're suggesting to this PR though. Are you asking for specific modifications to the proposed specification text, or is this a broader concern about BIDS organizational principles? If there's something actionable I can do here, I'm happy to consider it. But if the concern is about how BIDS has historically organized modalities, that seems like a separate discussion from whether audio/video/events should live together in beh/. |
Yes it is in my case. I haven't been able to follow on this particular PR so please don't take my message for an objection. |
same here. and it is not an objection, but that people coming to this will see two conflicting grouping mechanisms. a note added to the PR to the general section (or in the beh section) in relation to these two grouping mechanisms would help people understand the difference and perhaps help addressing (by some group) in the future. |
|
Here are the issues relating to potentially changing the folder organization within BIDS, I think it is better to discuss it among those and leave this BEP in alignment with current state of allowing P.S. Also in general let's prefer commenting on the diff, instead of using the main thread here, since we cannot easily group of related comments out from within main thread. |
IMHO, this is a problem of today. It'd be great that BIDS 2.0 had an elegant/more consistent response. However, BIDS needs to address this for future BEPs (cc/ @ericearl) |
|
Let's continue on that in
|
whereas split already has to do with splitting large files:
though I can see in your case why you might want to use part, if you are splitting the stimulus up into logical components, like chapters of an audiobook. I don't mind terribly if we use different approaches for this. |
fix #1771
edit by @yarikoptic: preview - https://bids-specification--2231.org.readthedocs.build/en/2231/modality-specific-files/behavioral-experiments.html