Skip to content

fix: Include target entities in exact match check #273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 25, 2025
Merged

fix: Include target entities in exact match check #273

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bdae01a
test: Verify target entities do not trigger exact match logic
effigies Sep 22, 2025
fa67843
fix: Include target entities in exact match check
effigies Sep 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions src/files/inheritance.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,4 +72,22 @@ Deno.test('walkback inheritance tests', async (t) => {
assertEquals(rootElectrodes.path, '/space-talairach_electrodes.tsv')
},
)
await t.step(
'The presence of target entities does not trigger exact match logic',
async () => {
const rootFileTree = pathsToTree([
'/sub-01/ieeg/sub-01_task-rest_ieeg.edf',
'/sub-01/ieeg/sub-01_task-rest_space-anat_electrodes.tsv',
'/sub-01/ieeg/sub-01_task-rest_space-MNI_electrodes.tsv',
])
const dataFile = rootFileTree.get('sub-01/ieeg/sub-01_task-rest_ieeg.edf') as BIDSFile
const electrodes = walkBack(dataFile, true, ['.tsv'], 'electrodes', ['space'])
const localElectrodes: BIDSFile[] = electrodes.next().value
assert(Array.isArray(localElectrodes))
assertEquals(localElectrodes.map((f) => f.path), [
'/sub-01/ieeg/sub-01_task-rest_space-anat_electrodes.tsv',
'/sub-01/ieeg/sub-01_task-rest_space-MNI_electrodes.tsv',
])
},
)
})
2 changes: 1 addition & 1 deletion src/files/inheritance.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ export function* walkBack<T extends string[]>(
if (candidates.length > 1) {
const exactMatch = candidates.find((file) => {
const { entities } = readEntities(file.name)
return Object.keys(sourceParts.entities).every((entity) =>
return [...Object.keys(sourceParts.entities), ...(targetEntities ?? [])].every((entity) =>
entities[entity] === sourceParts.entities[entity]
)
})
Expand Down
Loading