✔ Fix User Socket Disconnect Dangling ~

bifeldy · Oct 14, 2023 · dff418f · dff418f
1 parent 512be19
commit dff418f
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 20 deletions.
diff --git a/dist/fansubid/browser/ngsw.json b/dist/fansubid/browser/ngsw.json
@@ -1,6 +1,6 @@
 {
   "configVersion": 1,
-  "timestamp": 1697257534887,
+  "timestamp": 1697259411691,
   "index": "/index.html",
   "assetGroups": [
     {

diff --git a/dist/fansubid/server/main.js b/dist/fansubid/server/main.js
diff --git a/src/api/gateways/socket-io.gateway.ts b/src/api/gateways/socket-io.gateway.ts
@@ -31,8 +31,6 @@ import { UserService } from '../repository/user.service';
 @WebSocketGateway()
 export class SocketIoGateway implements OnGatewayInit, OnGatewayConnection, OnGatewayDisconnect {
 
-  timeOutVisitor = null;
-
   constructor(
     private cms: ClusterMasterSlaveService,
     private cfg: ConfigService,
@@ -57,29 +55,19 @@ export class SocketIoGateway implements OnGatewayInit, OnGatewayConnection, OnGa
   handleConnection(client: Socket, ...args: any[]) {
     this.gs.log('[SOCKET_IO_GATEWAY-CLIENT_CONNECTED] 🌟', client.id);
     this.sis.checkNewNotification(client);
-    if (this.timeOutVisitor) {
-      clearTimeout(this.timeOutVisitor);
-    }
-    this.timeOutVisitor = setTimeout(async () => {
-      this.timeOutVisitor = null;
+    setTimeout(async () => {
       const totalSockets = (await this.sis.getAllClientsSocket()).length;
       this.ts.updateVisitor(`🏃‍♂️ ${totalSockets} Pengunjung`);
       this.sis.emitToBroadcast('visitor', totalSockets);
     }, 5 * 1000);
   }
 
-  handleDisconnect(client: Socket, ...args: any[]) {
+  async handleDisconnect(client: Socket, ...args: any[]) {
     this.gs.log('[SOCKET_IO_GATEWAY-CLIENT_DISCONNECTED] 🌟', client.id);
-    if (this.timeOutVisitor) {
-      clearTimeout(this.timeOutVisitor);
-    }
-    this.timeOutVisitor = setTimeout(async () => {
-      this.timeOutVisitor = null;
-      await this.sis.disconnectRoom(client);
-      const totalSockets = (await this.sis.getAllClientsSocket()).length;
-      this.sis.emitToBroadcast('visitor', totalSockets);
-      this.ts.updateVisitor(`🏃‍♂️ ${totalSockets} Pengunjung`);
-    }, 5 * 1000);
+    await this.sis.disconnectRoom(client);
+    const totalSockets = (await this.sis.getAllClientsSocket()).length;
+    this.sis.emitToBroadcast('visitor', totalSockets);
+    this.ts.updateVisitor(`🏃‍♂️ ${totalSockets} Pengunjung`);
   }
 
   /** */