Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

Feature/countdown timer #134

Open
wants to merge 21 commits into
base: develop
Choose a base branch
from
Open

Feature/countdown timer #134

wants to merge 21 commits into from

Conversation

con322
Copy link
Contributor

@con322 con322 commented Feb 1, 2019 •
edited
Loading

Proposed Changes

  • Countdown timer with options to set date to count down to, background colour or image and a title.
  • Added option to set reveal title, content, and link
  • Added option to hide the timer when finished

@jaymcp jaymcp added this to the v1.2.0 milestone Feb 4, 2019
jaymcp
jaymcp previously requested changes Feb 4, 2019
View reviewed changes
src/scripts/blocks/countdown-timer/DisplayComponent.js Show resolved Hide resolved
src/scripts/blocks/countdown-timer/DisplayComponent.js Outdated Show resolved Hide resolved
src/scripts/blocks/countdown-timer/DisplayComponent.js Outdated Show resolved Hide resolved
src/scripts/blocks/countdown-timer/DisplayComponent.js Outdated Show resolved Hide resolved
src/scripts/blocks/countdown-timer/DisplayComponent.js Outdated Show resolved Hide resolved
src/scripts/blocks/countdown-timer/DisplayComponent.js Outdated Show resolved Hide resolved
src/scripts/modules/countdown-timer.js Outdated Show resolved Hide resolved
src/scripts/modules/countdown-timer.js Outdated Show resolved Hide resolved
src/scripts/blocks/countdown-timer/DisplayComponent.js Outdated Show resolved Hide resolved
src/scripts/blocks/countdown-timer/index.js Outdated Show resolved Hide resolved
@con322 con322 dismissed jaymcp’s stale review February 11, 2019 16:37

code changes

@con322 con322 requested a review from jaymcp February 11, 2019 16:37
jaymcp
jaymcp previously requested changes Feb 12, 2019
View reviewed changes
src/scripts/blocks/countdown-timer/DisplayComponent.js Outdated Show resolved Hide resolved
src/scripts/blocks/countdown-timer/DisplayComponent.js Outdated Show resolved Hide resolved
src/scripts/blocks/countdown-timer/index.js Outdated Show resolved Hide resolved
includes/blocks/countdown-timer/reveal-content.php Outdated Show resolved Hide resolved
includes/blocks/countdown-timer/reveal-content.php Outdated Show resolved Hide resolved
src/scripts/blocks/countdown-timer/DisplayComponent.js Outdated Show resolved Hide resolved
src/scripts/modules/countdown-timer.js Outdated Show resolved Hide resolved
@con322 con322 dismissed jaymcp’s stale review February 12, 2019 15:36

code changes.

@con322 con322 requested a review from jaymcp February 12, 2019 15:36
jaymcp
jaymcp previously requested changes Feb 13, 2019
View reviewed changes
Copy link
Member

@jaymcp jaymcp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry mate 🙈

includes/blocks/countdown-timer/reveal-content.php Outdated Show resolved Hide resolved
includes/blocks/countdown-timer/reveal-content.php Outdated Show resolved Hide resolved
includes/blocks/countdown-timer/render.php Outdated Show resolved Hide resolved
includes/blocks/countdown-timer/render.php Outdated Show resolved Hide resolved
includes/blocks/countdown-timer/render.php Outdated Show resolved Hide resolved
includes/blocks/countdown-timer/render.php Outdated Show resolved Hide resolved
includes/blocks/countdown-timer/render.php Outdated Show resolved Hide resolved
includes/blocks/countdown-timer/render.php Outdated Show resolved Hide resolved
includes/blocks/countdown-timer/render.php Outdated Show resolved Hide resolved
src/scripts/modules/countdown-timer.js Outdated Show resolved Hide resolved
@con322 con322 dismissed jaymcp’s stale review February 13, 2019 14:55

Code review changes.

@con322 con322 requested a review from jaymcp February 13, 2019 14:55
jaymcp
jaymcp approved these changes Feb 13, 2019
View reviewed changes
Copy link
Member

@jaymcp jaymcp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for all your hard work on this!

@jaymcp jaymcp added the enhancement New feature or request label Feb 22, 2019
@ampersarnie
Copy link
Member

@jonmcp This is 4 years stale, is it still needed?

@jaymcp
Copy link
Member

jaymcp commented May 9, 2023

@ampersarnie i have no idea

@ampersarnie ampersarnie removed their request for review May 9, 2023 13:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jaymcp jaymcp jaymcp approved these changes

@scottblackburn scottblackburn Awaiting requested review from scottblackburn

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v1.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@con322 @ampersarnie @jaymcp