fix: DATA-11516 Add targetOrigin for postMessage calls #43
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Per title
Why?
Currently we are passing a wildcard (
*
) as a target when calling thewindow.postMessage
method. This allows attackers to intercept the messages. So that we need to specify target which should be current store's CP url.Testing / Proof
Manually tested on prod store. Verified both dev and prod environments. Verified that the messages e.g.
Cancel
orUse this
button click are only intercepted when the store URL is correct. F.e. on prod store when the app is running in dev mode, the buttons won't do anything.@bigcommerce/team-data