Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: visually editable PDP #1808

Draft
wants to merge 2 commits into
base: soul/integrations/makeswift
Choose a base branch
from

Conversation

agurtovoy
Copy link

@agurtovoy agurtovoy commented Dec 25, 2024

What/Why?

Make product detail page visually editable.

Testing

Kapture.2024-12-25.at.21.53.44.mp4

Copy link

linear bot commented Dec 25, 2024

Copy link

changeset-bot bot commented Dec 25, 2024

⚠️ No Changeset found

Latest commit: 203bfc2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Dec 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
catalyst-latest ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 3, 2025 2:50am
catalyst-soul ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 3, 2025 2:50am
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
catalyst ⬜️ Ignored (Inspect) Jan 3, 2025 2:50am
catalyst-au ⬜️ Ignored (Inspect) Visit Preview Jan 3, 2025 2:50am
catalyst-uk ⬜️ Ignored (Inspect) Visit Preview Jan 3, 2025 2:50am

@agurtovoy agurtovoy changed the base branch from main to soul/integrations/makeswift December 25, 2024 22:52
@agurtovoy agurtovoy changed the base branch from soul/integrations/makeswift to aleksey/vib-1043-component-theming December 25, 2024 22:52
@agurtovoy agurtovoy changed the title Aleksey/vib 908 pdp visual editing feat: visually editable PDP Dec 25, 2024
@agurtovoy agurtovoy force-pushed the aleksey/vib-908-pdp-visual-editing branch from 78a9973 to 61386d0 Compare December 25, 2024 23:06
@agurtovoy agurtovoy force-pushed the aleksey/vib-908-pdp-visual-editing branch from 61386d0 to 1044c5e Compare December 25, 2024 23:23
@agurtovoy agurtovoy force-pushed the aleksey/vib-908-pdp-visual-editing branch from 1044c5e to 69ddc30 Compare December 26, 2024 04:05
@agurtovoy agurtovoy force-pushed the aleksey/vib-908-pdp-visual-editing branch from 69ddc30 to 84742ae Compare December 26, 2024 16:49
@agurtovoy agurtovoy force-pushed the aleksey/vib-1043-component-theming branch 5 times, most recently from 624ef9d to 0fd8e93 Compare December 31, 2024 07:49
Base automatically changed from aleksey/vib-1043-component-theming to soul/integrations/makeswift December 31, 2024 17:10
Copy link
Contributor

github-actions bot commented Jan 3, 2025

⚡️🏠 Lighthouse report

Lighthouse ran against https://catalyst-latest-473bt96ux-bigcommerce-platform.vercel.app

🖥️ Desktop

We ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:

Category Score
🟢 Performance 97
🟢 Accessibility 94
🟢 Best practices 100
🟠 SEO 82

📱 Mobile

We ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:

Category Score
🟠 Performance 84
🟢 Accessibility 94
🟢 Best practices 100
🟠 SEO 85

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant