chore: upgrade next to 15.2.0-canary.1#1874
Merged
fikrikarim merged 1 commit intosoul/mainfrom Jan 8, 2025
Merged
Conversation
This release contain fixes for 404 revalidation issue with revalidateTag bug.
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
bookernath
approved these changes
Jan 8, 2025
fikrikarim
deleted the
fikri/eng-7189-follow-up-a-bug-in-nextjs-cannot-revalidate-404-page-with
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What/Why?
This release contains fixes for the 404 revalidation issue with
revalidateTag. vercel/next.js#74577One quirk about the issue is that this issue only appears when Next.js returns 404 as the HTTP status. Sometimes PPR will return 200 HTTP status even though we throw
notFoundinside a page. Related docs.To be able to reproduce this issue locally, I need to revert the temporary cookies() error commit. Otherwise, the not found page will have 200 as the HTTP status, and won't have this issue in the first place.
Testing
Before
revalidation-before.mp4
After
revalidation-after.mp4