Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(shipping): fixes incorrect README instructions for getSelectedShippingOption #1259

Merged
merged 1 commit into from
Oct 5, 2021

Conversation

jeffthemaximum
Copy link
Contributor

What?

  • fixes incorrect README instructions for getSelectedShippingOption

Why?

  • These docs misled me, so let's fix it!

Testing / Proof

@jeffthemaximum jeffthemaximum requested a review from a team as a code owner October 1, 2021 19:19
@jeffthemaximum jeffthemaximum changed the title fixes incorrect README instructions for getSelectedShippingOption docs(shipping): fixes incorrect README instructions for getSelectedShippingOption Oct 1, 2021
@jeffthemaximum
Copy link
Contributor Author

AFAIK my validate-commits check is failing for this same reason: #1137 (comment)

@jeffthemaximum
Copy link
Contributor Author

@bc-peng thanks for the approval. I'd love to merge this in, but the validate-commits CI check is failing, as described above.

@bc-peng
Copy link
Contributor

bc-peng commented Oct 5, 2021

@bc-peng thanks for the approval. I'd love to merge this in, but the validate-commits CI check is failing, as described above.

Hi Jeff. It's come to our team's attention to optimise the commit validation. We will solve this with #1137 together. Please bear with us.

@animesh1987
Copy link
Contributor

animesh1987 commented Oct 5, 2021

Hey @jeffthemaximum thanks for raising the fix. Can you please use CHECKOUT-0000 or GH-00 as part of the commit message i.e. docs(shipping): CHECKOUT-0000 fixes incorrect README instructions for getSelectedShippingOption for now.

We are in process of updating our commit lint tool, which will make this process much smoother.

Again sorry for the inconvenience caused.

@jeffthemaximum
Copy link
Contributor Author

@animesh1987 and @bc-peng thanks for the help. All my checks are now passing. I can't merged the PR, because Only those with write access to this repository can merge pull requests.. So, feel free to merge.

Also, while we're all here, any thoughts on #1157 ?

@animesh1987 animesh1987 merged commit 3acaf0e into bigcommerce:master Oct 5, 2021
@jeffthemaximum jeffthemaximum deleted the jeff/doc-typo-fix branch October 6, 2021 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants