remove deadlock #5
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of unpredictable network connections during consensus, a deadlock can be caused as below.
At
simple_pbft/pbft/network/proxy_server.gohttp.Postwill always wait until its response arrives. Whilehttp.Postis waiting,node.MsgDeliveryis blocked so thatresolveMsg()atsimple_pbft/pbft/network/node.gocan't deliver other msg. But the premise of thehttp.Postresponse’s arrival is that our node has processed the request msg of other nodes, so a deadlock is produced.To resolve the deadlock, we can use go routine to make node processes other msg while waiting the post response.