Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overhaul testing framework #71

Merged
merged 2 commits into from
Dec 12, 2024
Merged

Conversation

botandrose
Copy link

After an exhausting search through the current state of javascript testing frameworks, I settled on @web/test-runner.

Pros:

  1. Run tests with Firefox and Webkit in addition to Chrome
  2. Code coverage stats
  3. We're able to run CI on latest node
  4. The fetch permission issue with the perf tests is gone, rather than being worked around with a command line flag
  5. No longer using unmaintained software (mocha-chrome)

Cons:

  1. Can no longer just open the test/index.html file in a browser to run the tests in a browser and debug, have to run npm run debug instead
  2. CI takes around one minute to install dependencies, so CI runs are ~2 minutes instead of ~30 seconds.

Overall, I think its worth it. Thoughts?

coverage with Chrome, Firefox, and Webkit, code coverage stats, and now we're
running on latest node, too.
@botandrose
Copy link
Author

@1cg Okay two things:

  1. I've streamlined the npm test interface so now we can run e.g. npm test test/core.js
  2. I've just pushed TESTING.md, here it is rendered: https://github.com/bigskysoftware/idiomorph/blob/71d72e2a5f345aa8c829be75f5320436f5a7b6ee/TESTING.md

How does this look now?

@1cg 1cg merged commit 31617cd into bigskysoftware:main Dec 12, 2024
1 check passed
@botandrose botandrose deleted the web-test-runner branch December 12, 2024 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants