Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: simplify upload and download artifacts #682

Merged
merged 1 commit into from
Jan 12, 2025

Conversation

dianjuar
Copy link
Member

@dianjuar dianjuar commented Jan 12, 2025

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)

What is the current behavior?

Issue Number: #671

What is the new behavior?

GitHub Actions provides isolated artifact storage for each workflow run. Since artifacts are only shared between jobs within the same workflow run:

  1. There's no risk of name collisions between different runs
  2. Jobs can only access artifacts from their own workflow run
  3. Each run has its own isolated artifact storage space

The SHA suffixes were adding unnecessary complexity without providing any benefits for intra-workflow artifact sharing.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@dianjuar dianjuar merged commit 98ce4ab into main Jan 12, 2025
6 checks passed
@dianjuar dianjuar deleted the fix-sonar-for-contributors branch January 12, 2025 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant