Update for iOS8 #22
Open
Update for iOS8 #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this, @sn0! I was looking at this today myself, but I'm hesitant to merge it into master because I use this category in several iOS and OS X projects that support system versions prior to iOS 8 and OS X 10.10. I'd like to quiet the warnings, but not ignore them, but also not break compatibility (yet). Telling Xcode to ignore the warnings seems like a bad idea, but I could add a single #warning directive to remind us that for the time being we are using deprecated symbol names here. What do you think? |
|
That's a good point. I didn't think about compatibility. A single warning sounds good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just update calls which became deprecated in iOS8