Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempting to specify the format #10

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

Yoric
Copy link

@Yoric Yoric commented May 13, 2019

Here's a first attempt at specifying the format.

@dominiccooney, did I get it right?

Copy link

@arai-a arai-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

haven't yet done Nodes and probabilities part.
will review shortly.

format.md Outdated Show resolved Hide resolved
format.md Outdated Show resolved Hide resolved
format.md Outdated Show resolved Hide resolved
format.md Outdated Show resolved Hide resolved
format.md Outdated Show resolved Hide resolved


## Probability dictionaries

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about adding something like the following?
(just suggestion for later changes, not that they should be added in this PR)

  • the dictionary defines the possible AST, and code for each possibility to encode the actual tree in tree part of the file
  • the possible AST is the subset of the valid ECMAScript AST
  • If there's only one possibility at some node, it's fully defined in the dictionary
  • if there's 2 or more possibilities at some node, code in tree part defines which possibility to choose at that node
  • primitives values (excluding strings) and the length of lists are all defined in this dictionary, not in tree part

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tried clarifying in the latest version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants