Conversation
Closed
Member
|
Going to review this one after #10 is merged in. |
Egzavyer
force-pushed
the
14-enhance-basic-debugger
branch
from
b368f4c to
95a2c9d
Compare
jwt2706
requested changes
Feb 2, 2026
Member
jwt2706
left a comment
jwt2706
left a comment
There was a problem hiding this comment.
Everything looks good. Just some tiny nitpicks.
xsachax
reviewed
Feb 2, 2026
xsachax
reviewed
Feb 2, 2026
xsachax
reviewed
Feb 2, 2026
xsachax
reviewed
Feb 2, 2026
Member
|
Tests? |
xsachax
force-pushed
the
14-enhance-basic-debugger
branch
2 times, most recently
from
ca5dfee to
1d3ebb4
Compare
jwt2706
reviewed
Feb 4, 2026
Member
jwt2706
left a comment
jwt2706
left a comment
There was a problem hiding this comment.
Everything looks good. Just a couple of inquiries.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
feat: rewrite basic debugger and add proper bp handling docs: explain bp state machine
xsachax
force-pushed
the
14-enhance-basic-debugger
branch
from
0fe66f1 to
8744cd2
Compare
Member
|
TODO:
|
Member
Author
|
PR should be good to merge into main, its gotten massive and we had to rewrite a lot of portions many times so please look out for useless or ugly code. |
xsachax
reviewed
Feb 23, 2026
jwt2706
previously approved these changes
Feb 23, 2026
xsachax
reviewed
Feb 23, 2026
Member
xsachax
left a comment
xsachax
left a comment
There was a problem hiding this comment.
Full pass, a lot of stuff to look over
xsachax
approved these changes
Feb 23, 2026
Member
xsachax
left a comment
xsachax
left a comment
There was a problem hiding this comment.
Good work and good review session to keep quality high. Let's merge it!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sizeable PR that refactors most of the previous debugger logic. We all need to understand how the debugger actually works at a lower level, so please read this over and ask questions.