Skip to content

Commit

Permalink
Fix requested changes
Browse files Browse the repository at this point in the history
  • Loading branch information
Flipout50 committed Apr 2, 2024
1 parent 3f23a4f commit 33a0114
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 6 deletions.
1 change: 0 additions & 1 deletion libbs/api/decompiler_interface.py
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,6 @@ def _init_headless_components(self, *args, check_dec_path=True, **kwargs):
if not self._binary_path.exists():
raise FileNotFoundError("You must provide a valid target binary path when using headless mode.")


def _init_gui_components(self, *args, **kwargs):
from libbs.ui.version import set_ui_version
set_ui_version(self.qt_version)
Expand Down
7 changes: 2 additions & 5 deletions libbs/decompilers/ghidra/interface.py
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ def _ghidra_transaction(self: "GhidraDecompilerInterface", *args, **kwargs):
class GhidraDecompilerInterface(DecompilerInterface):
def __init__(self, loop_on_plugin=True, start_headless_watchers=False, **kwargs):
self.loop_on_plugin = loop_on_plugin
self.start_headless_watchers = start_headless_watchers
self._start_headless_watchers = start_headless_watchers

self._last_addr = None
self._last_func = None
Expand Down Expand Up @@ -65,14 +65,11 @@ def start_artifact_watchers(self):
# TODO: generalize superclass method?
super().start_artifact_watchers()

return

def stop_artifact_watchers(self):
if self._artifact_watchers_started:
self._data_monitor = None
# TODO: generalize superclass method?
super().stop_artifact_watchers()
return

def _init_headless_components(self, *args, **kwargs):
if self._headless_dec_path is None:
Expand Down Expand Up @@ -103,7 +100,7 @@ def _init_headless_components(self, *args, **kwargs):
if not self.connect_ghidra_bridge():
raise Exception(f"Failed to connect to the Ghidra Bridge. Check if the {self._headless_dec_path} binary was ever started.")

if self.start_headless_watchers:
if self._start_headless_watchers:
self.start_artifact_watchers()

def _find_headless_proc(self):
Expand Down

0 comments on commit 33a0114

Please sign in to comment.