Send URIs to unindex or remove via form data if more than one was provided #29
Conversation
- if uri parameter has more than one item, send content as URL-encoded body - add tests covering unindexing and removing more than one item - also add "file:" scheme on some examples of URI (they are more common than not) - change how the service mock validates some inputs - plugins and provider names: \w+ - URIs via dedicated function
callback should always be specified, although it may be undefined. This signature is better at preventing issues.
- accept dangling commas, which are not necessarily bad
- form data request body is already parsed, use it directly - retweak URI validation function to no longer use URL.parse
|
Tested with Dicoogle 3 and works fine. |
No strong opinion on this, I felt it just made the request simpler when it didn't need to have a response body. On the other hand, it would be simpler for the client to just provide these entries in a uniform fashion. I can change this to always send the URIs via form data. In the meantime, I noticed that the OpenAPI specification of the web API still refers to this property as a query property, so the spec should be updated accordingly. I filed bioinformatics-ua/dicoogle#512 for this. |
|
I'm fine with any option. |
optional parameter in impl signature of unindex
Resolves #28.