DcmSend: abort associations when I/O errors on C-STORE mid transfer #710
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses an edge case where a remote transfer association can hang indefinitely due to errors in the storage provider, such as corrupted storage data. Getting an
IOException
while invokingcstore
would result in the local store SCU proceeding to wait for a response from the SCP, even though it had not sent the final PData, resulting in both peers waiting for each other.The approach adopted here was to abort the association as soon as an
IOException
happens.