Distributions: Always show bars when no fitted distributions

biolab · Feb 14, 2025 · e4f262f · e4f262f
1 parent e67650f
commit e4f262f
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 2 deletions.
diff --git a/Orange/widgets/visualize/owdistributions.py b/Orange/widgets/visualize/owdistributions.py
@@ -698,7 +698,7 @@ def _cont_plot(self):
                 x0 + xoff, bar_width, 0,
                 [tot_freq if self.cumulative_distr else freq],
                 colors, stacked=False, expanded=False, tooltip=tooltip,
-                desc=desc, hidden=self.hide_bars)
+                desc=desc, hidden=self.controls.hide_bars.isChecked())
 
         if self.fitted_distribution:
             self._plot_approximations(
@@ -744,7 +744,7 @@ def _cont_split_plot(self):
                 x0 + xoff, bar_width, 0 if self.stacked_columns else 0.1,
                 plotfreqs,
                 gcolors, stacked=self.stacked_columns, expanded=self.show_probs,
-                hidden=self.hide_bars,
+                hidden=self.controls.hide_bars.isChecked(),
                 tooltip=self._split_tooltip(
                     desc, np.sum(plotfreqs), total, gvalues, plotfreqs),
                 desc=desc)

diff --git a/Orange/widgets/visualize/tests/test_owdistributions.py b/Orange/widgets/visualize/tests/test_owdistributions.py
@@ -524,6 +524,16 @@ def test_hide_bars(self):
             self.assertTrue(all(curve.opts["brush"] is not None
                                 for curve in widget.curve_items))
 
+        self._set_fitter(1)
+        self._set_check(widget.controls.hide_bars, True)
+        self.assertTrue(all(bar.hidden for bar in widget.bar_items))
+
+        self._set_fitter(0)
+        self.assertTrue(all(not bar.hidden for bar in widget.bar_items))
+
+        self._set_fitter(1)
+        self.assertTrue(all(bar.hidden for bar in widget.bar_items))
+
     def test_report(self):
         """Report doesn't crash"""
         widget = self.widget