[FIX] ScoringSheetViewer slider style and tooltip #7024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
❌ Your patch check has failed because the patch coverage (35.71%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #7024 +/- ##
==========================================
- Coverage 88.36% 88.35% -0.02%
==========================================
Files 332 332
Lines 73345 73360 +15
==========================================
+ Hits 64813 64816 +3
- Misses 8532 8544 +12 |
|
I like the change visually, but the tooltip doesn't work for me. Perhaps it is not necessary, since we see the exact probability below, but I kind like tooltips in general. |
janezd
reviewed
Feb 14, 2025
| # Draw a simple 2px wide black rectangle as the custom handle. | ||
| painter.save() | ||
| painter.setPen(Qt.NoPen) | ||
| painter.setBrush(Qt.black) |
There was a problem hiding this comment.
Use
painter.setBrush(QPalette().color(QPalette.WindowText))
to support dark mode.
| painter.save() | ||
| painter.setPen(Qt.NoPen) | ||
| painter.setBrush(Qt.black) | ||
| painter.drawRect(QRect(handle_rect.center().x() - 1, handle_rect.y(), 4, handle_rect.height())) |
There was a problem hiding this comment.
This hard rectangle looks Linux-y. Perhaps change to this?
painter.drawRoundedRect(QRect(handle_rect.center().x() - 1, handle_rect.y(),
3, handle_rect.height()),
3, 3)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #6985
Description of changes
Includes