Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(linter): implement solidjs usePerferFor #4295

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

fireairforce
Copy link
Contributor

Summary

Test Plan

@github-actions github-actions bot added A-Project Area: project A-Linter Area: linter L-JavaScript Language: JavaScript and super languages A-Diagnostic Area: diagnostocis labels Oct 14, 2024
Copy link

codspeed-hq bot commented Oct 14, 2024

CodSpeed Performance Report

Merging #4295 will degrade performances by 17.57%

Comparing fireairforce:perfer-for (9e9bfac) with main (d254b97)

Summary

❌ 7 regressions
✅ 92 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main fireairforce:perfer-for Change
js_analyzer[css_16118272471217147034.js] 17.9 ms 20.5 ms -12.71%
js_analyzer[index_3894593175024091846.js] 43.1 ms 49.7 ms -13.3%
js_analyzer[lint_13640784270757307929.ts] 33 ms 36.7 ms -10.19%
js_analyzer[parser_13571644119461115204.ts] 61.4 ms 71.3 ms -13.97%
js_analyzer[router_17129688031671448157.ts] 17.8 ms 21.5 ms -17.57%
js_analyzer[statement_263793315104667298.ts] 56.7 ms 67.7 ms -16.29%
js_analyzer[typescript_3735799142832611563.ts] 92.8 ms 112.2 ms -17.33%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Diagnostic Area: diagnostocis A-Linter Area: linter A-Project Area: project L-JavaScript Language: JavaScript and super languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant