Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(useExplicitType): support explicit function argument types #4463

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kaykdm
Copy link
Contributor

@kaykdm kaykdm commented Nov 4, 2024

Summary

related: #2017

This PR adds support for enforcing explicit type annotations on arguments in all functions and class methods. The rule is inspired by the explicit-module-boundary-types rule, but it expands coverage beyond exported functions to include all functions and methods within a class.

@github-actions github-actions bot added A-CLI Area: CLI A-Project Area: project A-Linter Area: linter L-JavaScript Language: JavaScript and super languages labels Nov 4, 2024
Copy link

codspeed-hq bot commented Nov 4, 2024

CodSpeed Performance Report

Merging #4463 will degrade performances by 9.81%

Comparing kaykdm:explicit-argument-types (925a373) with main (3f152b3)

Summary

⚡ 1 improvements
❌ 1 regressions
✅ 97 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main kaykdm:explicit-argument-types Change
pure_9395922602181450299.css[uncached] 4 ms 4.4 ms -9.81%
react.production.min_3378072959512366797.js[cached] 2 ms 1.8 ms +6.32%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-CLI Area: CLI A-Linter Area: linter A-Project Area: project L-JavaScript Language: JavaScript and super languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant