refactor(analyzer): use rule name for quick fix #4469
+379
−480
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR is the start of a refactor I have been doing in order to add a new feature in Biome via LSP.
The feature I am developing is meant for
next
, but this feature is harmless and it should be merged inmain
so all new rules are in line with the new way of creating action categories. Doing onnext
would increase the maintenance debt.This PR changes how the
ActionCategory
of rules is computed. Until now, all rules hadquickfix.biome
as action category, which was fine, With this PR, now all rules will have a personalised action category e.g.quickfix.biome.suspicious.noDebugger
. This will allow LSP users to decide which code actions to filter.Eventually, users will be able to decide which quick fixes to apply, but that will be for another PR.
Test Plan
The current tests should pass