Enforce using CURIEs for all relationships #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure about this one... I think there is actually an important distinction between a mappings from a generic to a species-specific term and between two species-specific terms. Is there really no alternative that captures the former? |
|
I put one in DeBiO a while ago - https://github.com/biopragmatics/debio/blob/dc70507790187f381d974e4368998ef83e0cf535/src/debio/resources/typedefs.json#L27C29-L31. This is like an ad-hoc ontology that I am keeping track of things missing from everywhere else |
|
Maybe better we suggest this to go in semapv directly |
cthoyt
force-pushed
the
relations-with-curies
branch
from
7d4acac
to
267b5a5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades the speciesSpecfic relation to use the
debio:0000003relation. It also adds a minimal test for relations being given as CURIEs.Note that discussion below was from before when I incorrectly used a
semapvrelation