-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added ArrayPloter and plotepiscan into Biotite #485
Conversation
Hi, thank you for contributing your work! I will probably need a few days for a proper review, but here are some initial comments:
|
Hi, I incorporated your suggestions and updated the PR. Thank you. |
Thanks. I am on vacation for a week in a few days, so maybe I will not be able to review your contribution before it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For now I would mainly request only some style changes, for which I made suggestions. Please check if the line length is still OK after accepting the suggestions. Furthermore I would propose that you add pandas
to environment.yml
, so that your example can be run in the automatic build of the documentation. In addition you might also add yourself to CONTRIB.rst
, if you like! I might bring up some additional points, as soon as I had time to execute you example.
Co-authored-by: Patrick Kunzmann <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, sorry for the delay, but finally I found time to finish the review. It looks mostly fine to me, there are mainly some small typos and docstring changes I would like to request.
######################################################################## | ||
# Create a signal map | ||
# ------------------- | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix rendering
# |
|
||
super().__init__(axes, color_symbols, font_size, font_param) | ||
self.fl_score = fl_score | ||
self._cmap = self._generate_colormap(colors["dimorange"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But the following lines call set_color:
biotite/src/biotite/sequence/graphics/alignment.py
Lines 1003 to 1004 in b86594b
if color is not None or cmap is not None: | |
symbol_plotter.set_color(color=color, cmap=cmap) |
I tested setting the color
parameter in plot_alignment_array()
in your example and it would lead to:
AttributeError: 'ArrayPlotter' object has no attribute 'set_color'
Hi, thanks for implementing the suggestions. The final plot has still some issue with its colorbar. If you cannot reproduce it, I will have a look on on it. |
Co-authored-by: Patrick Kunzmann <[email protected]>
I fixed the rendering of the final plot. It should be displaying correctly now. Thank you. |
Looks good to me. I would merge this PR as soon as the tests pass, if you are ready. |
I am willing to generalize ArrayPlotter as much as possible but It was not immediately clear to me how to do that . Comments and help are very appreciated.
thanks