Allow 5 characters residune names. #498
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for mentioning this, I was actually not aware of this change yet. Probably there changes on a larger scale necessary (e.g. an exception when writing PDB with 5-character residues), but this PR is already a good start. I will open an issue to tackle also the other places in the code base. |
|
As I had no push access to this branch, I created PR #512. In included you commit in the new PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello !
As you probably know, RCSB will soon be out of 3 characters codes to attribute to new ligands and plan to go for 5 characters codes before the end of the year (https://www.rcsb.org/news/65007774d78e004e766a969d).
This is an attempt of minimal modification to make Biotite compatible with such ligand codes.