Represent Alphabet symbols as tuple to improve performance
#629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
padix-key
force-pushed
the
alphabet
branch
4 times, most recently
from
dd2061a to
82eba31
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although an
Alphabetis immutable the baseAlphabetclass stores symbols in alist. To ensure immutabilityAlphabet.get_symbols()copies the internal list of symbols. In some scenarios this massively reduces the performance as some other methid, such as__len__()also callget_symbols().This PR improves performance by storing the symbols in a
tupleinstead of alist. This also conveys the message of immutability better.