Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve performance of pdbx.compress() #677

Merged
merged 2 commits into from
Oct 21, 2024
Merged

Improve performance of pdbx.compress() #677

merged 2 commits into from
Oct 21, 2024

Conversation

padix-key
Copy link
Member

No description provided.

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Oct 17, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #677 will improve performances by 43.35%

Comparing padix-key:compress-performance (446ad0a) with main (4ca6318)

Summary

⚡ 1 improvements
✅ 44 untouched benchmarks

Benchmarks breakdown

Benchmark main padix-key:compress-performance Change
⚡ benchmark_compress 721.7 ms 503.5 ms +43.35%

@padix-key padix-key force-pushed the compress-performance branch from 7012153 to 12f731d Compare October 17, 2024 12:55
@padix-key padix-key marked this pull request as ready for review October 17, 2024 13:24
@padix-key
Copy link
Member Author

Thanks for spotting the typos.

@padix-key @tjduigna
Fix typo in variable name
446ad0a 
Co-authored-by: Tom Duignan <[email protected]>
@padix-key padix-key merged commit 267f469 into biotite-dev:main Oct 21, 2024
27 checks passed
@padix-key padix-key deleted the compress-performance branch October 23, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tjduigna tjduigna tjduigna left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@padix-key @tjduigna