Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow failing PubChem tests due to busy server #680

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

padix-key
Copy link
Member

@padix-key padix-key commented Oct 18, 2024

Although the Dynamic Request Throttling is implemented in biotite.database.pubchem, it does not work properly, especially in the CI.

Hence, the PubChem tests are relaxed in this PR: A RequestError due to a busy PubChem server leads to a test skip and the PubChem doctests are omitted altogether.

Copy link

codspeed-hq bot commented Oct 18, 2024

CodSpeed Performance Report

Merging #680 will not alter performance

Comparing padix-key:pubchem (1c4e346) with main (4ca6318)

Summary

✅ 45 untouched benchmarks

@padix-key padix-key merged commit 9eb1b25 into biotite-dev:main Oct 21, 2024
27 checks passed
@padix-key padix-key deleted the pubchem branch October 23, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant