Fix wrong band width calculation under some circumstances #723
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
align_banded()
may return local alignments even iflocal=False
under rare circumstances.The problem was that band diagonals are trimmed to the size of the sequences (just to save memory), but under this cicumstances the band width is not updated. This allowed the trace to 'escape' the alignment band for low-scoring alignments leading to a premature traceback termination and thus local alignments instead of semi-global ones.