Skip to content

Commit

Permalink
remove explicit birdhouse_skip_ci: true from PR template (#432)
Browse files Browse the repository at this point in the history
## Overview

Remove explicit `birdhouse_skip_ci: true` from PR template
(note: this one above is left in there on purpose for the current PR)

When opening PRs, developers could easily leave in the `<!-- -->` comment about CI, causing the CI to falsely detect the condition when parsing the PR description, and ending up skipping it. Change the format of the sentence to avoid the false detection.

## Changes

**Non-breaking changes**
- Edit PR template.

**Breaking changes**
- n/a

## Related Issue / Discussion

- n/a

## CI Operations

Merging as-is without bump version due to no change to the platform infrastructure.
  • Loading branch information
fmigneault authored Mar 6, 2024
2 parents ca4b8ab + 76a1eb6 commit a7a45bc
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,12 @@ Links to other issues or sources.

- [ ] Things to do...

## CI Operations

<!--
The test suite can be run using a different DACCS config with ``birdhouse_daccs_configs_branch: branch_name`` in the PR description.
To globally skip the test suite regardless of the commit message use ``birdhouse_skip_ci: true`` in the PR description.
To globally skip the test suite regardless of the commit message use ``birdhouse_skip_ci`` set to ``true`` in the PR description.
Note that using ``[skip ci]``, ``[ci skip]`` or ``[no ci]`` in the commit message will override ``birdhouse_skip_ci`` from the PR description.
-->

birdhouse_daccs_configs_branch: master
Expand Down

0 comments on commit a7a45bc

Please sign in to comment.