-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update cowbird config with permission webhook cases #323
Conversation
E2E Test ResultsDACCS-iac Pipeline ResultsBuild URL : http://daccs-jenkins.crim.ca:80/job/DACCS-iac-birdhouse/1509/Result : failure BIRDHOUSE_DEPLOY_BRANCH : cowbird-permission-webhooks DACCS_CONFIGS_BRANCH : master PAVICS_E2E_WORKFLOW_TESTS_BRANCH : master PAVICS_SDI_BRANCH : master DESTROY_INFRA_ON_EXIT : true PAVICS_HOST : https://host-140-36.rdext.crim.ca PAVICS-e2e-workflow-tests Pipeline ResultsTests URL : http://daccs-jenkins.crim.ca:80/job/PAVICS-e2e-workflow-tests/job/master/1095/NOTEBOOK TEST RESULTS |
birdhouse/components/cowbird/config/cowbird/config.yml.template
Outdated
Show resolved
Hide resolved
E2E Test ResultsDACCS-iac Pipeline ResultsBuild URL : http://daccs-jenkins.crim.ca:80/job/DACCS-iac-birdhouse/1511/Result : success BIRDHOUSE_DEPLOY_BRANCH : cowbird-permission-webhooks DACCS_CONFIGS_BRANCH : master PAVICS_E2E_WORKFLOW_TESTS_BRANCH : master PAVICS_SDI_BRANCH : master DESTROY_INFRA_ON_EXIT : true PAVICS_HOST : https://host-140-36.rdext.crim.ca PAVICS-e2e-workflow-tests Pipeline ResultsTests URL : http://daccs-jenkins.crim.ca:80/job/PAVICS-e2e-workflow-tests/job/master/1097/NOTEBOOK TEST RESULTS |
@ChaamC You can either merge right away with bump versioning, or wait after Ouranosinc/cowbird#35 and do it all in one. As you prefer. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM as I do not really know the inner working between cowbird and magpie.
birdhouse/components/cowbird/config/cowbird/config.yml.template
Outdated
Show resolved
Hide resolved
… into cowbird-permission-webhooks
E2E Test ResultsDACCS-iac Pipeline ResultsBuild URL : http://daccs-jenkins.crim.ca:80/job/DACCS-iac-birdhouse/1620/Result : failure BIRDHOUSE_DEPLOY_BRANCH : cowbird-permission-webhooks DACCS_CONFIGS_BRANCH : master PAVICS_E2E_WORKFLOW_TESTS_BRANCH : master PAVICS_SDI_BRANCH : master DESTROY_INFRA_ON_EXIT : true PAVICS_HOST : https://host-140-92.rdext.crim.ca PAVICS-e2e-workflow-tests Pipeline ResultsTests URL : http://daccs-jenkins.crim.ca:80/job/PAVICS-e2e-workflow-tests/job/master/1164/NOTEBOOK TEST RESULTS |
E2E Test ResultsDACCS-iac Pipeline ResultsBuild URL : http://daccs-jenkins.crim.ca:80/job/DACCS-iac-birdhouse/1631/Result : failure BIRDHOUSE_DEPLOY_BRANCH : cowbird-permission-webhooks DACCS_CONFIGS_BRANCH : master PAVICS_E2E_WORKFLOW_TESTS_BRANCH : master PAVICS_SDI_BRANCH : master DESTROY_INFRA_ON_EXIT : true PAVICS_HOST : https://host-140-154.rdext.crim.ca PAVICS-e2e-workflow-tests Pipeline ResultsTests URL : http://daccs-jenkins.crim.ca:80/job/PAVICS-e2e-workflow-tests/job/master/1172/NOTEBOOK TEST RESULTS |
…vice types (#336) ## Overview In the cowbird `config.yml.template` file: the `wps_outputs` and `weaver` keys are supposed to be Magpie service types, not magpie service names. This causes all cowbird hooks to fail with: ``` cowbird.config.ConfigErrorInvalidServiceKey: Service `weaver` used in sync config is not valid since it was not found in Magpie services (['access', 'api', 'geoserver', 'geoserverwfs', 'geoserverwms', 'geoserverwps', 'ncwms', 'thredds', 'wfs', 'wps']). ``` This fix is already implemented in #323 but since that is waiting on Ouranosinc/cowbird#35 to get pulled in, this PR factors out the bugfix that isn't dependent on the cowbird PR. This allows us to fix this configuration bug in the meantime ## Changes **Non-breaking changes** None (bug fix) **Breaking changes** None ## Related Issue / Discussion ## Additional Information
… into cowbird-permission-webhooks
…-house/birdhouse-deploy into cowbird-permission-webhooks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code-wise, everything looks fine.
Need to get the test outputs posted on the PR to validate that everything works.
Maybe latest run failed due to cowbird==1.2.0
docker not yet released (not finished building)?
I was able to download the image |
Indeed. @Nazim-crim is investigating. |
run tests |
E2E Test ResultsDACCS-iac Pipeline ResultsBuild URL : http://daccs-jenkins.crim.ca:80/job/DACCS-iac-birdhouse/1794/Result : failure BIRDHOUSE_DEPLOY_BRANCH : cowbird-permission-webhooks DACCS_CONFIGS_BRANCH : master PAVICS_E2E_WORKFLOW_TESTS_BRANCH : master PAVICS_SDI_BRANCH : master DESTROY_INFRA_ON_EXIT : true PAVICS_HOST : https://host-140-92.rdext.crim.ca PAVICS-e2e-workflow-tests Pipeline ResultsTests URL : http://daccs-jenkins.crim.ca:80/job/PAVICS-e2e-workflow-tests/job/master/1212/NOTEBOOK TEST RESULTS |
🚀 🎉 |
E2E Test ResultsDACCS-iac Pipeline ResultsBuild URL : http://daccs-jenkins.crim.ca:80/job/DACCS-iac-birdhouse/1796/Result : failure BIRDHOUSE_DEPLOY_BRANCH : cowbird-permission-webhooks DACCS_CONFIGS_BRANCH : master PAVICS_E2E_WORKFLOW_TESTS_BRANCH : master PAVICS_SDI_BRANCH : master DESTROY_INFRA_ON_EXIT : true PAVICS_HOST : https://host-140-154.rdext.crim.ca PAVICS-e2e-workflow-tests Pipeline ResultsTests URL : http://daccs-jenkins.crim.ca:80/job/PAVICS-e2e-workflow-tests/job/master/1213/NOTEBOOK TEST RESULTS |
PR to add support to the new cases added to
Cowbird
, relates to cowbird PR #35.Changes
Fixes
sync_permissions
config which used invalid Magpie service types.