Clean up: Make bind-mount locations more flexible

[mishaschwartz]

Overview

Clean up unused variables and correct file paths from the changes made in 1.33.2

Changes

Non-breaking changes

Minor bug fix and code cleanup

Breaking changes

None

Related Issue / Discussion

From suggested changes: #356 (review)

Additional Information

birdhouse_daccs_configs_branch: master
birdhouse_skip_ci: false

[crim-jenkins-bot]

E2E Test Results

DACCS-iac Pipeline Results

Build URL : http://daccs-jenkins.crim.ca:80/job/DACCS-iac-birdhouse/2111/
Result : failure

BIRDHOUSE_DEPLOY_BRANCH : flexible-bind-mount-locations-bug-fix
DACCS_CONFIGS_BRANCH : master
PAVICS_E2E_WORKFLOW_TESTS_BRANCH : master
PAVICS_SDI_BRANCH : master

DESTROY_INFRA_ON_EXIT : true
PAVICS_HOST : https://host-140-154.rdext.crim.ca

PAVICS-e2e-workflow-tests Pipeline Results

Tests URL : http://daccs-jenkins.crim.ca:80/job/PAVICS-e2e-workflow-tests/job/master/1341/

NOTEBOOK TEST RESULTS

    
[2023-09-28T13:41:56.911Z] ============================= test session starts ==============================
[2023-09-28T13:41:56.911Z] platform linux -- Python 3.9.16, pytest-7.3.1, pluggy-1.0.0
[2023-09-28T13:41:56.911Z] rootdir: /home/jenkins/agent/workspace/PAVICS-e2e-workflow-tests_master
[2023-09-28T13:41:56.911Z] plugins: anyio-3.6.1, dash-2.10.0, nbval-0.9.6, tornasync-0.6.0.post2, xdist-3.3.1
[2023-09-28T13:41:56.911Z] collected 237 items
[2023-09-28T13:41:56.911Z] 
[2023-09-28T13:42:04.538Z] notebooks-auth/test_thredds.ipynb ...........                            [  4%]
[2023-09-28T13:42:13.111Z] pavics-sdi-master/docs/source/notebooks/WCS_example.ipynb .......        [  7%]
[2023-09-28T13:42:21.773Z] pavics-sdi-master/docs/source/notebooks/WFS_example.ipynb ......         [ 10%]
[2023-09-28T13:42:32.214Z] pavics-sdi-master/docs/source/notebooks/WMS_example.ipynb .F......       [ 13%]
[2023-09-28T13:49:54.041Z] pavics-sdi-master/docs/source/notebooks/climex.ipynb ............        [ 18%]
[2023-09-28T13:49:55.969Z] pavics-sdi-master/docs/source/notebooks/eccc-geoapi-climate-stations.ipynb . [ 18%]
[2023-09-28T13:50:04.565Z] ...............                                                          [ 25%]
[2023-09-28T13:50:14.287Z] pavics-sdi-master/docs/source/notebooks/eccc-geoapi-xclim.ipynb F.F..    [ 27%]
[2023-09-28T13:50:21.251Z] pavics-sdi-master/docs/source/notebooks/esgf-dap.ipynb ......            [ 29%]
[2023-09-28T13:50:38.251Z] pavics-sdi-master/docs/source/notebooks/forecasts.ipynb ......           [ 32%]
[2023-09-28T13:50:39.639Z] pavics-sdi-master/docs/source/notebooks/jupyter_extensions.ipynb .       [ 32%]
[2023-09-28T13:50:44.858Z] pavics-sdi-master/docs/source/notebooks/opendap.ipynb .......            [ 35%]
[2023-09-28T13:50:49.378Z] pavics-sdi-master/docs/source/notebooks/pavics_thredds.ipynb .....       [ 37%]
[2023-09-28T13:54:30.131Z] pavics-sdi-master/docs/source/notebooks/regridding.ipynb ............... [ 44%]
[2023-09-28T13:55:45.174Z] .............                                                            [ 49%]
[2023-09-28T13:55:47.360Z] pavics-sdi-master/docs/source/notebooks/rendering.ipynb ....             [ 51%]
[2023-09-28T13:55:49.574Z] pavics-sdi-master/docs/source/notebooks/subset-user-input.ipynb ........ [ 54%]
[2023-09-28T13:56:06.647Z] .................                                                        [ 62%]
[2023-09-28T13:56:13.841Z] pavics-sdi-master/docs/source/notebooks/subsetting.ipynb ......          [ 64%]
[2023-09-28T13:56:15.227Z] pavics-sdi-master/docs/source/notebook-components/weaver_example.ipynb . [ 64%]
[2023-09-28T13:56:29.695Z] .........                                                                [ 68%]
[2023-09-28T13:56:38.941Z] finch-master/docs/source/notebooks/dap_subset.ipynb ...........          [ 73%]
[2023-09-28T13:56:47.980Z] finch-master/docs/source/notebooks/finch-usage.ipynb ......              [ 75%]
[2023-09-28T13:56:49.909Z] PAVICS-landing-master/content/notebooks/climate_indicators/PAVICStutorial_ClimateDataAnalysis-1DataAccess.ipynb . [ 76%]
[2023-09-28T13:56:52.465Z] ......                                                                   [ 78%]
[2023-09-28T13:56:59.051Z] PAVICS-landing-master/content/notebooks/climate_indicators/PAVICStutorial_ClimateDataAnalysis-2Subsetting.ipynb . [ 79%]
[2023-09-28T13:57:13.945Z] .............                                                            [ 84%]
[2023-09-28T13:57:23.943Z] PAVICS-landing-master/content/notebooks/climate_indicators/PAVICStutorial_ClimateDataAnalysis-3Climate-Indicators.ipynb . [ 85%]
[2023-09-28T13:58:00.545Z] ....s.                                                                   [ 87%]
[2023-09-28T13:58:08.683Z] PAVICS-landing-master/content/notebooks/climate_indicators/PAVICStutorial_ClimateDataAnalysis-4Ensembles.ipynb . [ 88%]
[2023-09-28T13:58:22.823Z] ...                                                                      [ 89%]
[2023-09-28T13:58:37.741Z] PAVICS-landing-master/content/notebooks/climate_indicators/PAVICStutorial_ClimateDataAnalysis-5Visualization.ipynb . [ 89%]
[2023-09-28T13:59:01.081Z] ......                                                                   [ 92%]
[2023-09-28T13:59:02.805Z] notebooks/hummingbird.ipynb ............                                 [ 97%]
[2023-09-28T14:01:42.416Z] notebooks/stress-tests.ipynb ......                                      [100%]
[2023-09-28T14:01:42.416Z] 
[2023-09-28T14:01:42.416Z] =================================== FAILURES ===================================
    
  

[tlvu]

LGTM

[crim-jenkins-bot]

E2E Test Results

DACCS-iac Pipeline Results

Build URL : http://daccs-jenkins.crim.ca:80/job/DACCS-iac-birdhouse/2124/
Result : failure

BIRDHOUSE_DEPLOY_BRANCH : flexible-bind-mount-locations-bug-fix
DACCS_CONFIGS_BRANCH : master
PAVICS_E2E_WORKFLOW_TESTS_BRANCH : master
PAVICS_SDI_BRANCH : master

DESTROY_INFRA_ON_EXIT : true
PAVICS_HOST : https://

Infrastructure deployment failed. Instance has not been destroyed. @matprov