-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update DEFAULT_CONF_DIRS
to the minimal components required to deploy the stack
#399
Changes from 10 commits
b5bc400
357da73
a699efb
66ee207
35a8da3
7a2a627
1c02991
914f2ea
6517fd3
8a66b2e
95aa509
efd7e4c
f47480e
9100600
a1a1d05
e424083
227a028
39e7a6c
adbd1f5
1e32bcf
5ea5106
a7f1b81
9ff694a
48e6f21
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
./config | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Since we are purposely moving components, should we consider leaving this un-ignored? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think we have to ignore it so that the autoupdate code works. Right @tlvu ? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Since it would be a major update that could remove components if misconfigured, I guess it that it would feel safer to purposely break the autoupdate to have node admins make sure they set up their There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm not either so let's let @tlvu decide this one There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'd rather prefer not breaking the autodeploy. We had already the plan to do this: add the new paths in advance to However I would also ping PCIC in this PR so they are aware of this major change. |
mishaschwartz marked this conversation as resolved.
Show resolved
Hide resolved
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
version: "3.4" | ||
services: | ||
proxy: | ||
volumes: | ||
- ./components/canarie-api/config/proxy/conf.extra-service.d:/etc/nginx/conf.extra-service.d/canarie-api:ro | ||
- ./components/canarie-api/docker_configuration.py:/config/docker_configuration.py | ||
- ./components/canarie-api/entrypoint:/entrypoint:ro | ||
environment: | ||
CANARIE_API_CONFIG_FN: /config/docker_configuration.py | ||
CANARIE_MONITORING_EXTRA_CONF_DIR: ${CANARIE_MONITORING_EXTRA_CONF_DIR} | ||
entrypoint: /entrypoint |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -64,9 +64,14 @@ DELAYED_EVAL=" | |
COWBIRD_MONGODB_DATA_DIR | ||
" | ||
|
||
COMPONENT_DEPENDENCIES=" | ||
$COMPONENT_DEPENDENCIES | ||
./components/magpie | ||
" | ||
|
||
# this dependency is only required if the mongo instance is the one provided in config/mongodb. | ||
# (include this for Cowbird<2.0.0) | ||
#COMPONENT_DEPENDENCIES=" | ||
# $COMPONENT_DEPENDENCIES | ||
# ./config/mongodb | ||
# ./components/mongodb | ||
#" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Technically, There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should we even keep this since "this dependency is only required if the mongo instance is the one provided in config/mongodb (include this for Cowbird<2.0.0)" Is cowbird still <2.0.0? Else this comment block not needed anymore? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I wouldn't worry about There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. That's what I thought, no need to go back to older cowbird so no need to keep this comment block about adding mongodb as dependencies. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ok, I'll remove it |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
version: "3.4" | ||
services: | ||
proxy: | ||
volumes: | ||
- ./components/finch/config/canarie-api/canarie_api_monitoring.py:${CANARIE_MONITORING_EXTRA_CONF_DIR}/finch_canarie_api_monitoring.py:ro |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
version: "3.4" | ||
services: | ||
magpie: | ||
volumes: | ||
- ./components/finch/config/magpie/providers.cfg:${MAGPIE_PROVIDERS_CONFIG_PATH}/finch-providers.cfg:ro |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,4 +6,3 @@ service-config.json | |
geoserver_canarie_api_monitoring.py | ||
geoserver-magpie-provider.cfg | ||
config/proxy/canarie_api_monitoring.py | ||
config/magpie/providers.cfg | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Geoserver do not add to magpie providers anymore? But should we still keep this old ignore to avoid breaking autodeploy? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We need to remove this so that future changes to the providers.cfg file won't be ignored. It is no longer generated from a template file, it is part of the source code now. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Oh this is part of the source code now ! What would be the inconvenient to keep it as a template? We do not need any template substitutions now but we might need in the future so unless we are 100% sure we will never need substitution, I'd rather keep it a template. Anyways, let's forget about this file but for future files that are already a template, I would still keep them as template, even if we do not need substitution anymore. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ok let's leave this for now. I'd like to discuss this further at some point though because this feels very weird to me. It feels like we're adding a bunch of unnecessary restrictions to the code to avoid conflicts with the autoupdate mechanism. Another reason why I think #362 is a good idea. Let's discuss this further on that PR though |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
version: "3.4" | ||
services: | ||
proxy: | ||
volumes: | ||
- ./components/geoserver/config/canarie-api/canarie_api_monitoring.py:${CANARIE_MONITORING_EXTRA_CONF_DIR}/geoserver_canarie_api_monitoring.py:ro |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
version: "3.4" | ||
services: | ||
magpie: | ||
volumes: | ||
- ./components/geoserver/config/magpie/providers.cfg:${MAGPIE_PROVIDERS_CONFIG_PATH}/geoserver-providers.cfg:ro |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
version: "3.4" | ||
services: | ||
proxy: | ||
volumes: | ||
- ./components/geoserver/config/proxy/conf.extra-service.d:/etc/nginx/conf.extra-service.d/geoserver:ro |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
version: "3.4" | ||
services: | ||
proxy: | ||
volumes: | ||
- ./components/hummingbird/config/canarie-api/canarie_api_monitoring.py:${CANARIE_MONITORING_EXTRA_CONF_DIR}/hummingbird_canarie_api_monitoring.py:ro |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
version: "3.4" | ||
services: | ||
magpie: | ||
volumes: | ||
- ./components/hummingbird/config/magpie/providers.cfg:${MAGPIE_PROVIDERS_CONFIG_PATH}/hummingbird-providers.cfg:ro |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
version: "3.4" | ||
services: | ||
proxy: | ||
volumes: | ||
- ./components/jupyterhub/config/canarie-api/canarie_api_monitoring.py:${CANARIE_MONITORING_EXTRA_CONF_DIR}/jupyterhub_canarie_api_monitoring.py:ro |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
version: "3.4" | ||
services: | ||
magpie: | ||
volumes: | ||
- ./components/jupyterhub/config/magpie/providers.cfg:${MAGPIE_PROVIDERS_CONFIG_PATH}/jupyter.cfg:ro |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
version: "3.4" | ||
services: | ||
proxy: | ||
volumes: | ||
- ./components/jupyterhub/config/proxy/conf.extra-service.d:/etc/nginx/conf.extra-service.d/jupyterhub:ro |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
version: "3.4" | ||
services: | ||
proxy: | ||
volumes: | ||
- ./components/magpie/config/canarie-api/canarie_api_monitoring.py:${CANARIE_MONITORING_EXTRA_CONF_DIR}/magpie_canarie_api_monitoring.py:ro |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
version: "3.4" | ||
services: | ||
proxy: | ||
volumes: | ||
- ./components/magpie/config/proxy/conf.extra-service.d:/etc/nginx/conf.extra-service.d/magpie:ro |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
version: "3.4" | ||
services: | ||
proxy: | ||
volumes: | ||
- ./components/portainer/config/proxy/conf.extra-service.d:/etc/nginx/conf.extra-service.d/portainer:ro |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -8,7 +8,11 @@ export PROXY_READ_TIMEOUT_VALUE="240s" | |
|
||
# Content of "location /" in file config/proxy/conf.d/all-services.include.template | ||
# Useful to have a custom homepage. | ||
export PROXY_ROOT_LOCATION="return 302 https://\$host/jupyter/hub/login;" | ||
# If the jupyterhub component is enabled, this default will be overridden and the location will become the jupyterhub | ||
# login page instead (see components/jupyterhub/default.env). | ||
# If jupyterhub is not enabled, we recommend overriding this with a custom homepage since the magpie landing page isn't | ||
# the most user-friendly location. | ||
export PROXY_ROOT_LOCATION="return 302 https://\$host/magpie;" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I saw that the same variable is set by default when enabling There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
If jupyterhub is enabled it will always override the magpie settings in There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ok. Makes sense. I would add a comment that explicit this assumption, and indicate that this is only as last resort default if nothing else was enabled. Realistically, Magpie should probably not be the entrypoint, but we need "something" to fill the variable. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Add this comment about magpie as landing page is not the most user-friendly location to the var |
||
|
||
export INCLUDE_FOR_PORT_80='$([ x"$ALLOW_UNSECURE_HTTP" = x"True" ] && echo "include /etc/nginx/conf.d/all-services.include;" || echo "include /etc/nginx/conf.d/redirect-to-https.include;")' | ||
|
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
version: "3.4" | ||
services: | ||
proxy: | ||
volumes: | ||
- ./components/raven/config/canarie-api/canarie_api_monitoring.py:${CANARIE_MONITORING_EXTRA_CONF_DIR}/raven_canarie_api_monitoring.py:ro |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
version: "3.4" | ||
services: | ||
magpie: | ||
volumes: | ||
- ./components/raven/config/magpie/providers.cfg:${MAGPIE_PROVIDERS_CONFIG_PATH}/raven-providers.cfg:ro |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
version: "3.4" | ||
services: | ||
proxy: | ||
volumes: | ||
- ./components/thredds/config/canarie-api/canarie_api_monitoring.py:${CANARIE_MONITORING_EXTRA_CONF_DIR}/thredds_canarie_api_monitoring.py:ro |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
version: "3.4" | ||
services: | ||
magpie: | ||
volumes: | ||
- ./components/thredds/config/magpie/providers.cfg:${MAGPIE_PROVIDERS_CONFIG_PATH}/thredds-providers.cfg:ro |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
version: "3.4" | ||
services: | ||
proxy: | ||
volumes: | ||
- ./components/thredds/config/proxy/conf.extra-service.d:/etc/nginx/conf.extra-service.d/thredds:ro | ||
links: | ||
- thredds |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
version: "3.4" | ||
services: | ||
proxy: | ||
volumes: | ||
- ./components/twitcher/config/canarie-api/canarie_api_monitoring.py:${CANARIE_MONITORING_EXTRA_CONF_DIR}/twitcher_canarie_api_monitoring.py:ro |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
version: "3.4" | ||
services: | ||
proxy: | ||
volumes: | ||
- ./components/twitcher/config/proxy/conf.extra-service.d:/etc/nginx/conf.extra-service.d/twitcher:ro |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given that
./components/jupyterhub
is not enabled by default anymore, but./components/stac
is, it might be worth mentioning that addingPROXY_ROOT_LOCATION
explicitly could be required depending on which components are enabled, and which one the node manager desires to put as default redirect (if any).