Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

node details overrides + logging utils #415

Merged
merged 44 commits into from
Feb 23, 2024
Merged

node details overrides + logging utils #415

merged 44 commits into from
Feb 23, 2024

Commits on Dec 15, 2023

  1. node details overrides + logging utils

    @fmigneault
    fmigneault committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    9c67f68 View commit details
    Browse the repository at this point in the history

  2. remove old config

    @fmigneault
    fmigneault committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    4a5ed09 View commit details
    Browse the repository at this point in the history

  3. update changes

    @fmigneault
    fmigneault committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    adda409 View commit details
    Browse the repository at this point in the history

  4. update unittests with new birdhouse/scripts/read-configs.include.sh path

    @fmigneault
    fmigneault committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    6be39d8 View commit details
    Browse the repository at this point in the history

  5. adjust cd exit 1 code

    @fmigneault
    fmigneault committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    805e5da View commit details
    Browse the repository at this point in the history

  6. replace all THIS_FILE with readlink|realpath cmd

    @fmigneault
    fmigneault committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    816292b View commit details
    Browse the repository at this point in the history

Commits on Dec 19, 2023

  1. replace backticks by $(...) for path resolution operations

    @fmigneault
    fmigneault committed Dec 19, 2023
    Configuration menu
    Copy the full SHA
    a41dd91 View commit details
    Browse the repository at this point in the history

  2. fix canarie-api config conflict

    @fmigneault
    fmigneault committed Dec 19, 2023
    Configuration menu
    Copy the full SHA
    d9fb457 View commit details
    Browse the repository at this point in the history

Commits on Jan 8, 2024

  1. update changes

    @fmigneault
    fmigneault committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    eff7dd3 View commit details
    Browse the repository at this point in the history

  2. add log function and logging level support

    @fmigneault
    fmigneault committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    1d30103 View commit details
    Browse the repository at this point in the history

Commits on Jan 11, 2024

  1. add security defaults check for required variables that should be mod… 

    …ified
    @fmigneault
    fmigneault committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    6a75a10 View commit details
    Browse the repository at this point in the history

Commits on Jan 12, 2024

  1. add note about deprecated vars defaults

    @fmigneault
    fmigneault committed Jan 12, 2024
    Configuration menu
    Copy the full SHA
    8692201 View commit details
    Browse the repository at this point in the history

Commits on Jan 16, 2024

  1. jupyterhub: ensure username variables are respected everywhere

    @mishaschwartz
    mishaschwartz committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    c92e6a0 View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2024

  1. Merge branch 'master' into fix-node-details

    @fmigneault
    fmigneault authored Jan 19, 2024
    Configuration menu
    Copy the full SHA
    92c3fab View commit details
    Browse the repository at this point in the history

Commits on Jan 22, 2024

  1. ensure change is backwards compatible

    @mishaschwartz
    mishaschwartz committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    4fd9d01 View commit details
    Browse the repository at this point in the history

  2. unittest

    @mishaschwartz
    mishaschwartz committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    7390245 View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2024

  1. adjust sourced config file to standardize across scripts

    @fmigneault
    fmigneault committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    7ea0f63 View commit details
    Browse the repository at this point in the history

  2. remove duplicate nested include of logging utils

    @fmigneault
    fmigneault committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    2d120a1 View commit details
    Browse the repository at this point in the history

  3. adjust pre/post compose script to include -x command display only on … 

    …debug log level
    @fmigneault
    fmigneault committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    7314005 View commit details
    Browse the repository at this point in the history

  4. add double quotes around default values

    @fmigneault
    fmigneault committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    17c5a94 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'fix-node-details' of https://github.com/bird-house/bird… 

    …house-deploy into fix-node-details
    @fmigneault
    fmigneault committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    ec77c07 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'master' into fix-node-details

    @fmigneault
    fmigneault authored Jan 23, 2024
    Configuration menu
    Copy the full SHA
    88e8ab3 View commit details
    Browse the repository at this point in the history

  7. revert canarie config invalid template vars values

    @fmigneault
    fmigneault committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    58b2c4c View commit details
    Browse the repository at this point in the history

  8. Merge branch 'fix-node-details' into security-defaults

    @mishaschwartz
    mishaschwartz authored Jan 23, 2024
    Configuration menu
    Copy the full SHA
    1c8b615 View commit details
    Browse the repository at this point in the history

  9. Merge branch 'fix-node-details' of https://github.com/bird-house/bird… 

    …house-deploy into fix-node-details
    @fmigneault
    fmigneault committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    ba2c863 View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2024

  1. replace missed logging call

    @fmigneault
    fmigneault committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    3cae728 View commit details
    Browse the repository at this point in the history

  2. Magpie: ensure that the MAGPIE_ADMIN_USERNAME variable is respected (… 

    …#418)

## Overview

We checked that all username variables are respected in the source code.
We checked that there are no instances of the default being hardcoded
(the assumption being that no one would ever actually change the
variable from the default).

The only issue found was that the `MAGPIE_ADMIN_USERNAME` variable was
not used to set the default value for `JUPYTERHUB_ADMIN_USERS` properly.

## Changes

**Non-breaking changes**
- Updates default value for `JUPYTERHUB_ADMIN_USERS` to respect other
variable settings

**Breaking changes**

## Related Issue / Discussion

- Resolves #417 

## Additional Information

Links to other issues or sources.


<!--
The test suite can be run using a different DACCS config with
``birdhouse_daccs_configs_branch: branch_name`` in the PR description.
To globally skip the test suite regardless of the commit message use
``birdhouse_skip_ci: true`` in the PR description.
-->

birdhouse_daccs_configs_branch: master
birdhouse_skip_ci: false
    @mishaschwartz
    mishaschwartz authored Jan 25, 2024
    Configuration menu
    Copy the full SHA
    24950ba View commit details
    Browse the repository at this point in the history

  3. add check_default_vars to read_basic_configs_only

    @fmigneault
    fmigneault committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    adb54c7 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'fix-node-details' of https://github.com/bird-house/bird… 

    …house-deploy into fix-node-details
    @fmigneault
    fmigneault committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    1e53f57 View commit details
    Browse the repository at this point in the history

  5. replace check_required_vars exit by return

    @fmigneault
    fmigneault committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    22a161f View commit details
    Browse the repository at this point in the history

  6. add comments from PR review

    @fmigneault
    fmigneault committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    e17649b View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2024

  1. move discover_compose_dir to resolve COMPOSE_DIR and reuse it to sour… 

    …ce logging utilities
    @fmigneault
    fmigneault committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    bcfe94c View commit details
    Browse the repository at this point in the history

  2. fix missing echo -> log conversions

    @fmigneault
    fmigneault committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    f59a1e1 View commit details
    Browse the repository at this point in the history

  3. adjustments from PR review

    @fmigneault
    fmigneault committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    151c8a5 View commit details
    Browse the repository at this point in the history

  4. move compose list resolution and 'info' mode handling before pre-dock… 

    …er-compose-up script handling
    @fmigneault
    fmigneault committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    13392c8 View commit details
    Browse the repository at this point in the history

Commits on Feb 16, 2024

  1. Merge branch 'master' into fix-node-details

    @mishaschwartz
    mishaschwartz authored Feb 16, 2024
    Configuration menu
    Copy the full SHA
    ccb97b5 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into fix-node-details

    @mishaschwartz
    mishaschwartz authored Feb 16, 2024
    Configuration menu
    Copy the full SHA
    193bdb1 View commit details
    Browse the repository at this point in the history

Commits on Feb 20, 2024

  1. do not export __DEFAULT__ variables

    @fmigneault
    fmigneault committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    85d2910 View commit details
    Browse the repository at this point in the history

  2. reuse __DEFAULT__ values for env.local.example

    @fmigneault
    fmigneault committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    dbc79a3 View commit details
    Browse the repository at this point in the history

  3. add COMPOSE_DIR check if provided explicitly

    @fmigneault
    fmigneault committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    442d2f2 View commit details
    Browse the repository at this point in the history

  4. revert read-configs.include.sh move + unify variables/escapes/quote-exec

    @fmigneault
    fmigneault committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    9649cf3 View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2024

  1. fix read-configs.include.sh location in unittests

    @fmigneault
    fmigneault committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    85a258a View commit details
    Browse the repository at this point in the history

  2. adjust comments about __DEFAULT__ variables

    @fmigneault
    fmigneault committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    ebf070f View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2024

  1. Bump version: 2.0.6 → 2.1.0

    @fmigneault
    fmigneault committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    0dbd31d View commit details
    Browse the repository at this point in the history