Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

env.local.example: fix JUPYTERHUB_CONFIG_OVERRIDE comment section #424

Merged
merged 1 commit into from
Feb 16, 2024

Conversation

tlvu
Copy link
Collaborator

@tlvu tlvu commented Feb 16, 2024

JUPYTERHUB_CONFIG_OVERRIDE was disconnected from its sample code.

This is just a comment fix. Zero chance to introduce any regressions.

I won't tag it upon merging this PR.

It was disconnected from its sample code.
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Feb 16, 2024
@crim-jenkins-bot
Copy link
Collaborator

E2E Test Results

DACCS-iac Pipeline Results

Build URL : http://daccs-jenkins.crim.ca:80/job/DACCS-iac-birdhouse/2480/
Result : failure

BIRDHOUSE_DEPLOY_BRANCH : fix-wrong-comment-location-in-env.local.example
DACCS_CONFIGS_BRANCH : master
PAVICS_E2E_WORKFLOW_TESTS_BRANCH : master
PAVICS_SDI_BRANCH : master

DESTROY_INFRA_ON_EXIT : true
PAVICS_HOST : https://host-140-154.rdext.crim.ca

PAVICS-e2e-workflow-tests Pipeline Results

Tests URL : http://daccs-jenkins.crim.ca:80/job/PAVICS-e2e-workflow-tests/job/master/1522/

NOTEBOOK TEST RESULTS
    
[2024-02-16T03:46:36.376Z] ============================= test session starts ==============================
[2024-02-16T03:46:36.376Z] platform linux -- Python 3.9.16, pytest-7.3.1, pluggy-1.0.0
[2024-02-16T03:46:36.376Z] rootdir: /home/jenkins/agent/workspace/PAVICS-e2e-workflow-tests_master
[2024-02-16T03:46:36.376Z] plugins: anyio-3.6.1, dash-2.10.0, nbval-0.9.6, tornasync-0.6.0.post2, xdist-3.3.1
[2024-02-16T03:46:36.376Z] collected 264 items
[2024-02-16T03:46:36.376Z] 
[2024-02-16T03:46:47.280Z] notebooks-auth/geoserver.ipynb ..................                        [  6%]
[2024-02-16T03:47:22.011Z] notebooks-auth/test_cowbird_jupyter.ipynb ..........                     [ 10%]
[2024-02-16T03:47:26.002Z] notebooks-auth/test_thredds.ipynb ...........                            [ 14%]
[2024-02-16T03:47:34.944Z] pavics-sdi-master/docs/source/notebooks/WCS_example.ipynb .......        [ 17%]
[2024-02-16T03:47:45.029Z] pavics-sdi-master/docs/source/notebooks/WFS_example.ipynb ......         [ 19%]
[2024-02-16T03:47:51.608Z] pavics-sdi-master/docs/source/notebooks/WMS_example.ipynb .FFFFFFF       [ 22%]
[2024-02-16T03:55:12.787Z] pavics-sdi-master/docs/source/notebooks/climex.ipynb ............        [ 27%]
[2024-02-16T03:55:12.787Z] pavics-sdi-master/docs/source/notebooks/eccc-geoapi-climate-stations.ipynb . [ 27%]
[2024-02-16T03:55:18.633Z] ...............                                                          [ 33%]
[2024-02-16T03:55:28.317Z] pavics-sdi-master/docs/source/notebooks/eccc-geoapi-xclim.ipynb .....    [ 35%]
[2024-02-16T03:56:40.911Z] pavics-sdi-master/docs/source/notebooks/esgf-dap.ipynb .....F            [ 37%]
[2024-02-16T03:56:52.441Z] pavics-sdi-master/docs/source/notebooks/forecasts.ipynb ......           [ 39%]
[2024-02-16T03:56:57.774Z] pavics-sdi-master/docs/source/notebooks/opendap.ipynb .......            [ 42%]
[2024-02-16T03:57:02.273Z] pavics-sdi-master/docs/source/notebooks/pavics_thredds.ipynb .....       [ 44%]
[2024-02-16T04:00:29.523Z] pavics-sdi-master/docs/source/notebooks/regridding.ipynb ............... [ 50%]
[2024-02-16T04:01:38.207Z] .............                                                            [ 54%]
[2024-02-16T04:01:40.415Z] pavics-sdi-master/docs/source/notebooks/rendering.ipynb ....             [ 56%]
[2024-02-16T04:01:42.563Z] pavics-sdi-master/docs/source/notebooks/subset-user-input.ipynb ........ [ 59%]
[2024-02-16T04:01:58.268Z] .................                                                        [ 65%]
[2024-02-16T04:02:07.235Z] pavics-sdi-master/docs/source/notebooks/subsetting.ipynb ......          [ 68%]
[2024-02-16T04:02:08.625Z] pavics-sdi-master/docs/source/notebook-components/weaver_example.ipynb . [ 68%]
[2024-02-16T04:02:26.446Z] .........                                                                [ 71%]
[2024-02-16T04:02:36.141Z] finch-master/docs/source/notebooks/dap_subset.ipynb ...........          [ 76%]
[2024-02-16T04:02:45.309Z] finch-master/docs/source/notebooks/finch-usage.ipynb ...F..              [ 78%]
[2024-02-16T04:02:46.691Z] PAVICS-landing-master/content/notebooks/climate_indicators/PAVICStutorial_ClimateDataAnalysis-1DataAccess.ipynb . [ 78%]
[2024-02-16T04:02:49.769Z] ......                                                                   [ 81%]
[2024-02-16T04:02:56.353Z] PAVICS-landing-master/content/notebooks/climate_indicators/PAVICStutorial_ClimateDataAnalysis-2Subsetting.ipynb . [ 81%]
[2024-02-16T04:03:12.478Z] .............                                                            [ 86%]
[2024-02-16T04:03:22.484Z] PAVICS-landing-master/content/notebooks/climate_indicators/PAVICStutorial_ClimateDataAnalysis-3Climate-Indicators.ipynb . [ 86%]
[2024-02-16T04:03:58.062Z] ....s.                                                                   [ 89%]
[2024-02-16T04:04:06.226Z] PAVICS-landing-master/content/notebooks/climate_indicators/PAVICStutorial_ClimateDataAnalysis-4Ensembles.ipynb . [ 89%]
[2024-02-16T04:04:19.540Z] ...                                                                      [ 90%]
[2024-02-16T04:04:34.468Z] PAVICS-landing-master/content/notebooks/climate_indicators/PAVICStutorial_ClimateDataAnalysis-5Visualization.ipynb . [ 90%]
[2024-02-16T04:04:58.396Z] ......                                                                   [ 93%]
[2024-02-16T04:04:59.862Z] notebooks/hummingbird.ipynb ............                                 [ 97%]
[2024-02-16T04:08:01.056Z] notebooks/stress-tests.ipynb ......                                      [100%]
[2024-02-16T04:08:01.056Z] 
[2024-02-16T04:08:01.056Z] =================================== FAILURES ===================================
    
  

@tlvu tlvu merged commit 13645f3 into master Feb 16, 2024
4 of 5 checks passed
@tlvu tlvu deleted the fix-wrong-comment-location-in-env.local.example branch February 16, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants