Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix content-type of geoserver service-config.json.template #442

Merged
merged 2 commits into from
Apr 3, 2024

Conversation

fmigneault
Copy link
Collaborator

Overview

The /geoserver endpoint redirects to the HTML web view of the service.
Fix the indicated media-type of type for that endpoint in the service definition.

Changes

Non-breaking changes

  • fix content-type of GeoServer service-config.json.template

Breaking changes

  • n/a

Related Issue / Discussion

  • n/a

CI Operations

birdhouse_daccs_configs_branch: master
birdhouse_skip_ci: true

@fmigneault fmigneault self-assigned this Apr 3, 2024
@github-actions github-actions bot added component/geoserver Related to GeoServer or one of its underlying services feature/node-registry Related to https://github.com/DACCS-Climate/DACCS-node-registry labels Apr 3, 2024
Copy link
Collaborator

@mishaschwartz mishaschwartz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Please add a quick entry in CHANGES.md though

Copy link
Collaborator

@tlvu tlvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, same feedback as Misha to add a quick note to changelog.

@tlvu
Copy link
Collaborator

tlvu commented Apr 3, 2024

@fmigneault Why do you request our review again? We already approve and nothing have changed since the previous approval.

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Apr 3, 2024
@fmigneault
Copy link
Collaborator Author

@fmigneault Why do you request our review again? We already approve and nothing have changed since the previous approval.

GitHub UI didn't update on my end. You can ignore.

@fmigneault fmigneault merged commit 749c230 into master Apr 3, 2024
4 checks passed
@fmigneault fmigneault deleted the fix-geoserver-service-content-type branch April 3, 2024 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/geoserver Related to GeoServer or one of its underlying services documentation Improvements or additions to documentation feature/node-registry Related to https://github.com/DACCS-Climate/DACCS-node-registry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants