-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
weaver: bump version to 5.1.0 + debug notebook output #449
Conversation
…etry going +1 index
E2E Test ResultsDACCS-iac Pipeline ResultsBuild URL : http://daccs-jenkins.crim.ca:80/job/DACCS-iac-birdhouse/2612/Result ✅ SUCCESS BIRDHOUSE_DEPLOY_BRANCH : fix-weaver-retry DACCS_IAC_BRANCH : master DACCS_CONFIGS_BRANCH : master PAVICS_E2E_WORKFLOW_TESTS_BRANCH : master PAVICS_SDI_BRANCH : master DESTROY_INFRA_ON_EXIT : true PAVICS_HOST : https://host-140-154.rdext.crim.ca PAVICS-e2e-workflow-tests Pipeline ResultsTests URL : http://daccs-jenkins.crim.ca:80/job/PAVICS-e2e-workflow-tests/job/master/1586/NOTEBOOK TEST RESULTS |
@mishaschwartz |
Hold up! Weaver notebook was not actually tested during that run... weird. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I defer to Misha that knows more about Weaver than I do.
Found the cause. Due to invalid sourcing of PR in progress to fix (https://gitlab.com/crim.ca/clients/daccs/daccs-e2e-jenkins/-/merge_requests/33). Will rerun once integrated. |
E2E Test ResultsDACCS-iac Pipeline ResultsBuild URL : http://daccs-jenkins.crim.ca:80/job/DACCS-iac-birdhouse/2624/Result ❌ FAILURE BIRDHOUSE_DEPLOY_BRANCH : fix-weaver-retry DACCS_IAC_BRANCH : master DACCS_CONFIGS_BRANCH : master PAVICS_E2E_WORKFLOW_TESTS_BRANCH : master PAVICS_SDI_BRANCH : master DESTROY_INFRA_ON_EXIT : true PAVICS_HOST : https://host-140-154.rdext.crim.ca PAVICS-e2e-workflow-tests Pipeline ResultsTests URL : http://daccs-jenkins.crim.ca:80/job/PAVICS-e2e-workflow-tests/job/master/1590/NOTEBOOK TEST RESULTS |
Overview
Debugging cause of diff in final output of https://github.com/Ouranosinc/pavics-sdi/blob/master/docs/source/notebook-components/weaver_example.ipynb
Built on top of #439
Changes
Non-breaking changes
Related Issue / Discussion