Bump cadvisor version to the latest version: v0.49.1

[mishaschwartz]

Overview

• See the cadvisor repo for all changes: google/cadvisor@v0.36.0...v0.49.1
• This updated was prompted by the fact that the previously installed version of cadvisor (v0.36.0) did not support
  newer versions of docker. When deploying this repo with recent docker version, cadvisor was unable to discover or
  monitor running containers.

Changes

Non-breaking changes

• New component version cadvisor:v0.49.1

Breaking changes

Related Issue / Discussion

Additional Information

Links to other issues or sources.

• This PR builds on top of Make the monitoring component docker images configurable #457

CI Operations

birdhouse_daccs_configs_branch: master
birdhouse_skip_ci: false

[tlvu]

LGTM. The new version is backward compat with the settings we currently have in the docker-compose-extra.yml? And it plays nice with the older existing Prometheus?

[mishaschwartz]

The new version is backward compat with the settings we currently have in the docker-compose-extra.yml? And it plays nice with the older existing Prometheus?

Yes it seems to based on my tests on my local test machine

[tlvu]

Just to be sure, the new cadvisor version will still work with older docker-engine as well?

[mishaschwartz]

@tlvu

Just to be sure, the new cadvisor version will still work with older docker-engine as well?

Theoretically yes. I can try to test it out but I don't have any machines that are running the old version, so it might take me some time to configure a VM to test it. If you have VMs that are running an older version please feel free to check it out too

[mishaschwartz]

Just to be sure, the new cadvisor version will still work with older docker-engine as well?

Personally, I would rather the default support the modern version fo docker engine since most new deployments will use a relatively new version anyway.

If you need to support a legacy version of docker engine then you can always change the version of cadvisor in your deployment since the version is easily configurable since #457

[tlvu]

change the version of cadvisor in your deployment since the version is easily configurable since #457

Ah true, forgot about that one. Merge away then. We can override if needed.