Improve deploy-data flexibility to deploy files from other checkout in same config file #462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
ci/deployment
fmigneault
approved these changes
Jun 8, 2024
mishaschwartz
approved these changes
Jun 10, 2024
There was a problem hiding this comment.
I agree with @fmigneault. The change looks good but the description needs some clarification
|
Improved the changelog, let me know if it's clearer. |
tlvu
added a commit
to bird-house/birdhouse-deploy-ouranos
that referenced
this pull request
Jun 12, 2024
Need bird-house/birdhouse-deploy#462 to be merged first.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This is a non breaking change.
Given the config file can specify multiple checkouts, this flexibility to
have
SRC_DIRbe an absolute path will allow one checkout to take files fromother checkouts, using absolute path to the other checkouts.
SRC_DIRcanstill be a relative path of the current checkout, as before, to preserve
backward-compatibility.
Possible use-case: re-organize the layout of various files from the various
checkouts in an intermediate location before rsyncing this intermediate
location to the final destination.
CI Operations
birdhouse_daccs_configs_branch: master
birdhouse_skip_ci: false