Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Query builders for reference metadata queries #62

Merged
merged 16 commits into from
Jul 9, 2024
Merged

Query builders for reference metadata queries #62

merged 16 commits into from
Jul 9, 2024

Conversation

sosna
Copy link
Collaborator

@sosna sosna commented Jul 9, 2024

This PR adds support for the 3 types of reference metadata queries supported in the SDMX-REST API.

javihern98
javihern98 approved these changes Jul 9, 2024
View reviewed changes
Copy link
Contributor

@javihern98 javihern98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good on our side, this part of the standard (Reference Metadata on Metadataflows) is not related to anything we have ever implemented, so review is based only on code structure and test quality, which seems really nice :)

@sosna sosna merged commit 33c7831 into develop Jul 9, 2024
14 checks passed
@sosna sosna deleted the qb_refmeta branch July 9, 2024 15:08
@sosna
Copy link
Collaborator Author

sosna commented Jul 9, 2024

Thanks, @javihern98. The builder for data queries is coming next :)

@sosna sosna linked an issue Jul 18, 2024 that may be closed by this pull request
Implement SDMX-REST query builders #70
Closed
@sosna sosna removed a link to an issue Jul 18, 2024
Implement SDMX-REST query builders #70
Closed
@sosna sosna linked an issue Jul 18, 2024 that may be closed by this pull request
Implement SDMX-REST query builders #70
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javihern98 javihern98 javihern98 approved these changes

@stratosn stratosn Awaiting requested review from stratosn

@antonio-olleros antonio-olleros Awaiting requested review from antonio-olleros

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement SDMX-REST query builders
2 participants
@sosna @javihern98