BUGFIX: Running scripts may be loaded before main UI #1726
+174
−38
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we load running scripts, those scripts may run before the main UI is loaded. In that case, anything that interacts with the router will fail to run. For example, Singularity APIs that call
Router.toPage()
will throw an error, and that error may not be shown to the player because the main UI is not loaded.How to reproduce:
If you cannot reproduce it consistently, you can forcefully delay the main UI: In
src\ui\LoadingScreen.tsx
, add another promise (e.g.,new Promise((resolve) => setTimeout(resolve, 1000))
) to[initSwc(), Engine.load(saveData)]
.Test code:
Closes #1707.