Move various state computations from the UI to the NodeModel #434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of having the UI compute the formatted version of verification progress using js, move this computation into the nodemodel; where it belongs. The UI is the UI, and the backend is the backend.
Instead of having the UI compute when the node is connected to the network, move this computation into the nodemodel; where it belongs. The UI is the UI, and the backend is the backend.
Instead of having the UI compute when the node is synced, move this computation into the nodemodel; where it belongs. The UI is the UI, and the backend is the backend.
Instead of having the UI construct the formatted version of the remaining sync time as well as computing when the node is estimating the remaining sync time using js, move this construction and computation into the nodemodel; where it belongs. The UI is the UI, and the backend is the backend.
This is not needed, and we cannot have any javascript functions.
There was a problem hiding this comment.
cr ACK
It looks much cleaner. Regarding the formatting, as discussed offline, I'd take it out from the NodeModel, I think it's not its responsibility and not related with business logic and the node itself, I'd create a separate object to make the formatting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To enforce clear seperation between the UI and the backend, as well as to begin the removal of any js functions, this shifts the following string construction and state computations from the UI into the NodeModel itself (which is where it belongs)
These strings and states are now available and reusable wherever they may be needed, instead of needing to be computed by every file which needs that information.
As a rule, the UI should have no computation of any sorts outside of things related to UI specific ideas such as color or sizing; any other computation needs to be strictly done in our backend.