Initial Template for Request Payment page #435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The piece I'm most concerned about this form is the Amount input field and how to properly sanitize and convert the field. The current object backing it doesnt quite feel right but I am limited by the inability to extend the actual TextInput class. |
johnny9
changed the title
MarnixCroes
reviewed
Nov 22, 2024
| { | ||
| QString result = text; | ||
|
|
||
| // Remove any invalid characters |
There was a problem hiding this comment.
Is this the right thing to do?
QT gui simply refuses to paste when there are invalid characters.
yeah there are a couple weird things:
|
This control is primarily used in wallet forms where the user is expected to input values for sending or receiving transactions. It contains a Label describing the input as well as a TextInput where the actual string is entered. A Icon is also available on the right side of the component for extra actions.
The copy icon will be used to initiate a copy to clipboard when it is clicked.
The flip-veritcal icon is primarily used when flipping the units displayed when clicked
The pending icon will be used to show the status of transactions
johnny9
force-pushed
the
request-payment-form
branch
from
1b869eb
to
e642461
Compare
BitcoinAmount is a helper object can be used to manage inputs in sats or btc.
This page contains the form for the user to fill out to create a payment request.
This page contains the details of a payment request. It is pushed onto the RequestPayment page's stack after the user has clicke don Continue.
johnny9
force-pushed
the
request-payment-form
branch
from
e642461
to
adff8f2
Compare
|
From from 1b869eb to adff8f
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These commits introduce the Request Payment flow. This view is available under the "Receive" tab on the Desktop Wallets main navigation view.
The Request Payment form itself currently only includes fields currently supported by the Qt wallet (label, message, and amount). Follow up PR will add support for local notes.
The Amount field in the Request form takes only valid Satoshi/Bitcoin amounts and supports flipping the units with the associated button toggle.
When the Continue button is pressed the Request Confirmation page gets pushed to the stack will eventually reflect the fields inputted in the previous form backed by the output of the WalletModel result. In its current implemention it just has statically defined properties to check the visual layout. The page also contains an address field with the copy icon that can be used to move the address into your clipboard.
Ubuntu screenshots
