Introduce the Desktop Wallet Activity Page #442
Conversation
johnny9
force-pushed
the
activity-page
branch
from
a07c7f2 to
bf4cfd7
Compare
| @@ -122,9 +122,8 @@ Page { | |||
| width: parent.width | |||
| height: parent.height | |||
| currentIndex: navigationTabs.checkedButton.index | |||
| Item { | |||
| Activity { | |||
There was a problem hiding this comment.
it builds, but doesn't run
./bitcoin-qt -signet
QSocketNotifier: Can only be used with threads started with QThread
QQmlApplicationEngine failed to load component
qrc:/qml/pages/main.qml:83:9: Type DesktopWallets unavailable
qrc:/qml/pages/wallet/DesktopWallets.qml:125:9: Activity is not a type
~InitExecutor : Stopping thread
~InitExecutor : Stopped thread
There was a problem hiding this comment.
Updated the PR to include the missing component
There was a problem hiding this comment.
Concept ACK
Light tACK 357611e on regtest.
-
Wallet main's activity page.
-
Activity's details page.
I think you could add the screenshots to the PR's description.
I found @GBKS's prototype for the activity page here, perhaps you could also add it to the top as a reference. I think the icons need to be updated (for send and receive) same for the magnifying glass search icon at the top right (follow-up?).
Not part of this PR's code I think but while testing, in order to update the activity page contents, switching among the different wallets doesn't work, at least for me, can't remember if it was already an issue or wasn't intended to work yet.
I'd reduce the amount of commits and make a clean up (eg in 1st commit you add some empty files that you remove on the 2nd, perhaps you only amend the 1st commit removing them and delete the 2nd commit?).
johnny9
force-pushed
the
activity-page
branch
7 times, most recently
from
1fa72da to
8971438
Compare
|
Tested on Ubuntu
|
hebasto
changed the title
|
Needs rebase. |
There was a problem hiding this comment.
ACK 28ede4b, I have skimmed through the code and it looks OK.
@johnny9
Please ensure that you the clang-format-diff.py tool to your changes before pushing.
This commit introduces the basic Activity Page and Activity details Page. The pages are backed by activitylistmodel which queries the wallet interface and converts the WalletTx objects into Transaction objects in the list that returns the properties for each send/receive to one of our wallet's addresses.