-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix on TransactionsView - Disable if privacy mode is set during wallet selection #815
base: master
Are you sure you want to change the base?
Conversation
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. ConflictsNo conflicts as of last run. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested ACK d3da502
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This feels like the wrong place to fix it. Why not inside setWalletActionsEnabled
(or whatever is enabling it to begin with)?
Yeah, it makes more sense, I'll rework it. Thanks! |
d3da502
to
6c3b027
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm pretty sure you can just modify the existing line in setWalletActionsEnabled
to:
historyAction->setEnabled(enabled && !isPrivacyModeActivated());
|
6c3b027
to
6180086
Compare
This one-line change works without anything else: |
Sorry, I made another mistake, thanks for double checking. To other reviewers: please hold on till next push, thanks. |
Making sure that if the privacy mode is activaded during the wallet selection, the transaction view is not shown.
6180086
to
260d6eb
Compare
Updates:
|
@pablomartin4btc Did you consider bitcoinknots/bitcoin#83? |
Yeah, in fact the "switch to Overview" tab when changing/ selecting wallets, was introduced in #718, I can fix it here in a 2nd. commit which will do soon. |
Sure about PR number? ('cause there is no such a number in this repo) |
oh! my bad.. a typo there... how lucky! I'll play the lottery with that one today... I meant #708, I think it's the only place related to the "mask value" where I switched to the overview tab when the mask value checkbox on the menu is ticked but still need to check it. |
@hebasto, I couldn't reproduce the issue described in bitcoinknots/bitcoin#83, trying both |
@hebasto, the issue mentioned in bitcoinknots/bitcoin#83 is fixed by this PR. |
Currenlty on
master
, when the "mask values" checkbox is ticked if the user selects a different wallet, the history action is enable and if the user clicks on it can see all the transactions in the transaction view.This PR fixes it.
Note for maintainers: this needs to be backported to 25.x and 26.x.