-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GUIUtil::brintToFront workaround for Wayland #831
GUIUtil::brintToFront workaround for Wayland #831
Conversation
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. ConflictsNo conflicts as of last run. |
🚧 At least one of the CI tasks failed. HintsMake sure to run all tests locally, according to the documentation. The failure may happen due to a number of reasons, for example:
Leave a comment here, if you need help tracking down a confusing failure. |
f27d285
to
bcc6874
Compare
Concept ACK. |
e4dfc7e
to
19f8842
Compare
19f8842
to
15aa7d0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 15aa7d0.
Tested on Ubuntu 24.04. The behavior with QT_QPA_PLATFORM=wayland
has become more consistent with the behavior with QT_QPA_PLATFORM=xcb
.
Tested on macOS 12.7.6 Monterey. No behavior changes observed.
There are known issues around handling windows focus in
Wayland
(this one specific in KDE but also in gnome).The idea is that the workaround will be executed if
bitcoin-qt
is running usingWayland
platform (e.g.:QT_QPA_PLATFORM=wayland ./src/qt/bitcoin-qt -regtest
), since the workaround behaviour looks like re-opening the window again (which I tried to fix by moving the window to the original position and/ or re-setting the original geometry without success) while inX11
(not sure in Mac) the currentGUIUtil::brintToFront
actually sets the focus to the desired window, keeping its original position as expected, and I didn't want to change that (X11
behaviour).The solution was initially discussed with hebasto in #817.